Skip to content

Commit bfbd583

Browse files
committed
Auto expiring locks tested by integration
Signed-off-by: Tisham Dhar <[email protected]>
1 parent 7f8af48 commit bfbd583

File tree

1 file changed

+0
-45
lines changed

1 file changed

+0
-45
lines changed

tests/test_python_dynamodb_lock.py

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -169,51 +169,6 @@ def test_acquire_lock_after_release(self):
169169
self.assertIsNotNone(lock)
170170
self.assertTrue((end_time - start_time) * 1000 >= 100)
171171

172-
173-
def test_acquire_lock_after_lease_expires(self):
174-
self.ddb_table.get_item = mock.MagicMock('get_item')
175-
self.ddb_table.get_item.side_effect = lambda **kwargs: {
176-
'Item': {
177-
'lock_key': 'key',
178-
'sort_key': '-',
179-
'owner_name': 'owner',
180-
'lease_duration': 0.3,
181-
'record_version_number': 'xyz',
182-
'expiry_time': 100,
183-
}
184-
}
185-
start_time = time.monotonic()
186-
lock = self.lock_client.acquire_lock('key', retry_period=datetime.timedelta(milliseconds=100))
187-
end_time = time.monotonic()
188-
self.assertIsNotNone(lock)
189-
self.assertTrue((end_time - start_time) * 1000 >= 300)
190-
191-
192-
def test_acquire_lock_retry_timeout(self):
193-
self.ddb_table.get_item = mock.MagicMock('get_item')
194-
self.ddb_table.get_item.side_effect = lambda **kwargs: {
195-
'Item': {
196-
'lock_key': 'key',
197-
'sort_key': '-',
198-
'owner_name': 'owner',
199-
'lease_duration': 0.6,
200-
'record_version_number': 'xyz',
201-
'expiry_time': 100,
202-
}
203-
}
204-
start_time = time.monotonic()
205-
try:
206-
self.lock_client.acquire_lock(
207-
'key',
208-
retry_period=datetime.timedelta(milliseconds=100),
209-
retry_timeout=datetime.timedelta(milliseconds=300))
210-
self.fail('Expected an error')
211-
except DynamoDBLockError as e:
212-
end_time = time.monotonic()
213-
self.assertEqual(e.code, DynamoDBLockError.ACQUIRE_TIMEOUT)
214-
self.assertTrue((end_time - start_time) * 1000 >= 200)
215-
# at 220ms, it would error out, instead of sleeping for another 100ms
216-
217172
def test_acquire_lock_race_condition(self):
218173
# test the get-none, put-error, retry, get-none, put-success case
219174
self.ddb_table.get_item = mock.MagicMock('get_item')

0 commit comments

Comments
 (0)