Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links highlighted on wrong pane relative to other pane mouse position #6766

Open
doprz opened this issue Mar 7, 2025 · 4 comments
Open

Links highlighted on wrong pane relative to other pane mouse position #6766

doprz opened this issue Mar 7, 2025 · 4 comments
Labels
bug Something isn't working needs:triage

Comments

@doprz
Copy link

doprz commented Mar 7, 2025

What Operating System(s) are you seeing this problem on?

Linux Wayland

Which Wayland compositor or X11 Window manager(s) are you using?

Wayland and GNOME 47

WezTerm version

wezterm 20250306_153218_72123274

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

No, and I'll explain why below

Describe the bug

For example, if you split the wezterm session into halves to have 2 panes. Select the left pane with links and hover your mouse on the right pane (with left pane still selected), the links on the left pane will get underlined using the mouse coordinates of the right pane despite the mouse not being directly over the links.

To Reproduce

No response

Configuration

no config

Expected Behavior

Links should be underlined when the mouse is hovering over them and not in another pane.

Logs

No response

Anything else?

Thank you for the amazing work with wezterm!

@doprz doprz added bug Something isn't working needs:triage labels Mar 7, 2025
@digitallyserviced
Copy link
Contributor

@doprz

I recently came across something similar. However it was with links in the same pane that had the same link/url

I would ask if the other panes hyperlinks that activate as if hovered, possess the same underlying link/url as the one you are actually hovering over.

If this is the case, while it may not be expected, I'm not sure it is actually to be considered an issue. To me it would make sense and also be helpful that similar links are conveyed.

@bew
Copy link
Member

bew commented Mar 15, 2025

the links on the left pane will get underlined using the mouse coordinates of the right pane despite the mouse not being directly over the links.

I not 100% sure I understand what you're saying, I originally thought you were describing a bug where something random is underlined in another pane. But @digitallyserviced's message seems to say that all links that are the same are underlined without distinction of the pane (note: iirc Wez said it was easier to impl this way).

@doprz So which one do you have? 🤔
Could you give a screenshot/cast example?

@doprz
Copy link
Author

doprz commented Mar 18, 2025

I was able to reproduce the issue, for reference I have the right pane selected while I hover my mouse over the links in the left pane.

Image

@digitallyserviced
Copy link
Contributor

digitallyserviced commented Mar 19, 2025

I was able to reproduce the issue, for reference I have the right pane selected while I hover my mouse over the links in the left pane.

Image

@doprz
I see this is definitely not expected and looks like it does the checks for mouse location relative to pane coords only without also checking if the mouse is actually in the pane relative to the window/tab.

Proper bug and will have a look see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:triage
Projects
None yet
Development

No branches or pull requests

3 participants