Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodash imports #5

Open
nason opened this issue Jul 17, 2017 · 0 comments
Open

Lodash imports #5

nason opened this issue Jul 17, 2017 · 0 comments

Comments

@nason
Copy link
Contributor

nason commented Jul 17, 2017

The problem

@GLosch and others have made the case that import _ from 'lodash' is preferable to import { foo } from 'lodash'. Opening this to capture that concern and to open a channel for discussion.

https://github.com/eslint-plugins/eslint-plugin-lodash/blob/master/docs/rules/import.md is a nice way to enfore the named-import approach. I'm sure something exists for the whole lib approach, or we could make a custom rule.

This is also app specific and relates to things like https://github.com/lodash/babel-plugin-lodash, and https://github.com/lodash/lodash-webpack-plugin, but I agree some degree of consistency across apps here would be 💯

This was referenced Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant