Refine Block/Log types when not using pending block tag

[frolic]

I am fetching blocks/logs with block tags other than pending, but I still get a bunch of optional types for things like blockNumber, transactionHash, etc.

I am currently working around this by wrapping the types (below), but it would be nice if viem took into consideration the block tag or whether the returned block/log could be pending (similar to strict log parsing). Pending feels like a less common use case, so being able to opt-in might save some conditionals in user land.

import type { Block } from "viem";

export type NonPendingBlock<TBlock extends Block> = TBlock & {
  hash: NonNullable<TBlock["hash"]>;
  logsBloom: NonNullable<TBlock["logsBloom"]>;
  nonce: NonNullable<TBlock["nonce"]>;
  number: NonNullable<TBlock["number"]>;
};

export function isNonPendingBlock<TBlock extends Block>(block: TBlock): block is NonPendingBlock<TBlock> {
  return block.hash != null && block.logsBloom != null && block.nonce != null && block.number != null;
}

import type { Log } from "viem";

export type NonPendingLog<TLog extends Log> = TLog & {
  blockHash: NonNullable<TLog["blockHash"]>;
  blockNumber: NonNullable<TLog["blockNumber"]>;
  logIndex: NonNullable<TLog["logIndex"]>;
  transactionHash: NonNullable<TLog["transactionHash"]>;
  transactionIndex: NonNullable<TLog["transactionIndex"]>;
};

export function isNonPendingLog<TLog extends Log>(log: TLog): log is NonPendingLog<TLog> {
  return (
    log.blockHash != null &&
    log.blockNumber != null &&
    log.logIndex != null &&
    log.transactionHash != null &&
    log.transactionIndex != null
  );
}

[jxom]

#847

[frolic]

beautiful, thank you!