Apply suggestions from code review

Co-authored-by: Ten0 <[email protected]>

Author: weiznich

diesel/src/sqlite/connection/bind_collector.rs

@@ -96,10 +96,13 @@ impl<'a> BindCollector<'a, Sqlite> for SqliteBindCollector<'a> {
             .map_err(crate::result::Error::SerializationError)?;
         let bind = to_sql_output.into_inner();
         let metadata = Sqlite::metadata(metadata_lookup);
-        match is_null {
-            IsNull::No => self.binds.push((bind, metadata)),
-            IsNull::Yes => self.binds.push((SqliteBindValue::Null, metadata)),
-        }
+        self.binds.push((
+            match is_null {
+                IsNull::No => bind,
+                IsNull::Yes => SqliteBindValue::Null,
+            },
+            metadata,
+        ));
         Ok(())
     }
 }

diesel/src/sqlite/connection/stmt.rs

@@ -253,6 +253,8 @@ impl<'stmt, 'query> BoundStatement<'stmt, 'query> {
     {
         // Don't use a trait object here to prevent using a virtual function call
         // For sqlite this can introduce a measurable overhead
+        // Query is boxed here to make sure it won't move in memory anymore, so any bind
+        // it could output would stay valid.
         let query = Box::new(query);
 
         let mut bind_collector = SqliteBindCollector::new();