Skip to content

Commit ac61f20

Browse files
authored
Closing mdns agent (#636)
I use the library with many open/close, and I get mdns storms where the webrtc library searches for other nodes over the network in a very aggressive manner. This has been proposed by @r-byondlabs, and might very well be the problem: if I open/close many connections, and the mdns-agents are not cleaned up, there might be many requests. Fixes #616
1 parent fc3a0aa commit ac61f20

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

ice/src/agent/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,8 @@ impl Agent {
349349
udp_mux.remove_conn_by_ufrag(&ufrag).await;
350350
}
351351

352+
Self::close_multicast_conn(&self.mdns_conn).await;
353+
352354
//FIXME: deadlock here
353355
self.internal.close().await
354356
}

sctp/fuzz/fuzz_targets/packet.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#![no_main]
22
use libfuzzer_sys::fuzz_target;
33

4-
use webrtc_sctp::packet::Packet;
54
use bytes::Bytes;
5+
use webrtc_sctp::packet::Packet;
66

77
fuzz_target!(|data: &[u8]| {
88
let bytes = Bytes::from(data.to_vec());

sctp/fuzz/fuzz_targets/param.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#![no_main]
22
use libfuzzer_sys::fuzz_target;
33

4-
use webrtc_sctp::param::build_param;
54
use bytes::Bytes;
5+
use webrtc_sctp::param::build_param;
66

77
fuzz_target!(|data: &[u8]| {
88
let bytes = Bytes::from(data.to_vec());

0 commit comments

Comments
 (0)