Skip to content

Commit bb539eb

Browse files
committed
Fix imports & formatting
1 parent 4ae54d6 commit bb539eb

File tree

4 files changed

+26
-23
lines changed

4 files changed

+26
-23
lines changed

_examples/golang-basics/example.gen.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

_examples/golang-imports/api.gen.go

+4-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

imports.go.tmpl

+12-6
Original file line numberDiff line numberDiff line change
@@ -80,22 +80,28 @@ import (
8080
{{- set $imports $opts.importTypesFrom "" -}}
8181
{{- else -}}
8282
{{- range $_, $type := $types -}}
83-
{{- range $_, $field := $type.Fields -}}
84-
{{- range $meta := $field.Meta -}}
83+
{{- /* TODO: We might need to loop through method args too. */ -}}
84+
{{- range $meta := $type.Meta -}}
8585
{{- if exists $meta "go.type.import" -}}
8686
{{- set $imports (get $meta "go.type.import") "" -}}
8787
{{- end -}}
8888
{{- end -}}
89-
{{- end -}}
89+
{{- if $opts.types }}
90+
{{- range $_, $field := $type.Fields -}}
91+
{{- range $meta := $field.Meta -}}
92+
{{- if exists $meta "go.type.import" -}}
93+
{{- set $imports (get $meta "go.type.import") "" -}}
94+
{{- end -}}
95+
{{- end -}}
96+
{{- end -}}
97+
{{- end }}
9098
{{- end -}}
9199
{{- end }}
92-
{{- if $opts.types }}
93100
{{ range $import, $rename := $imports }}
94101
{{- if not (exists $stdlibImports $import)}}
95102
{{if ne $rename ""}}{{$rename}} {{end}}"{{$import}}"
96-
{{end}}
103+
{{- end }}
97104
{{- end }}
98-
{{- end -}}
99105
)
100106

101107
{{- if eq $opts.json "jsoniter" }}

types.go.tmpl

+8-8
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,17 @@
55
{{- $services := .Services -}}
66
{{- $opts := .Opts -}}
77

8-
{{- if $types }}
98
//
10-
// Types
9+
// Common types
1110
//
1211
{{ range $_, $type := $types -}}
1312

1413
{{- if eq $type.Kind "enum" }}
1514
{{- if eq $type.Type.Expr "string" }}
1615
{{template "enum_string" dict "Name" $type.Name "Type" $type.Type "TypePrefix" $typePrefix "Fields" $type.Fields "Opts" $opts}}
17-
{{ else }}
16+
{{- else }}
1817
{{template "enum" dict "Name" $type.Name "Type" $type.Type "TypePrefix" $typePrefix "Fields" $type.Fields "Opts" $opts}}
19-
{{ end -}}
18+
{{- end -}}
2019
{{ end -}}
2120

2221
{{- if and (eq $type.Kind "struct") $opts.types }}
@@ -28,8 +27,7 @@
2827
{{template "struct" dict "Name" $type.Name "TypeMap" $typeMap "TypePrefix" $typePrefix "Fields" $type.Fields}}
2928
{{ end -}}
3029

31-
{{ end }}
32-
{{ end -}}
30+
{{- end }}
3331

3432
var WebRPCServices = map[string][]string{
3533
{{- range $_, $service := $services}}
@@ -46,6 +44,7 @@ var WebRPCServices = map[string][]string{
4644
//
4745

4846
{{ range $_, $service := $services -}}
47+
{{ if $opts.types -}}
4948
type {{$service.Name}} interface {
5049
{{- range $_, $method := $service.Methods}}
5150
{{ if eq $method.StreamOutput true -}}
@@ -56,9 +55,10 @@ type {{$service.Name}} interface {
5655

5756
{{- end}}
5857
}
58+
{{- end }}
5959

60-
{{- range $_, $method := $service.Methods}}
61-
{{ if eq $method.StreamOutput true -}}
60+
{{- range $_, $method := $service.Methods -}}
61+
{{ if eq $method.StreamOutput true }}
6262
type {{$method.Name}}StreamWriter interface {
6363
Write({{range $i, $output := $method.Outputs}}{{if gt $i 0}}, {{end}}{{$output.Name}} {{template "field" dict "Name" $output.Name "Type" $output.Type "Optional" $output.Optional "TypeMap" $typeMap "TypePrefix" $typePrefix "TypeMeta" $output.Meta}}{{end}}) error
6464
}

0 commit comments

Comments
 (0)