Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate automatic blocking of cookie popups #182

Closed
ikreymer opened this issue Nov 14, 2022 · 3 comments
Closed

Investigate automatic blocking of cookie popups #182

ikreymer opened this issue Nov 14, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@ikreymer
Copy link
Member

Brave recently added a feature for blocking cookie popups, I believe it is using: https://easylist.to/ cookie list.
If this works well enough as a Brave feature for users, we should definitely look into adding this as an option for the crawler!
I assume this could work similarly to the ad block, where we download the list and then apply it as part of the request handling to add cookies?

@tw4l
Copy link
Member

tw4l commented Nov 17, 2022

The question is whether to implement in the browsertrix-crawler code via #187 or to switch to using Brave in the crawler with a custom profile, which would net the same result and possibly have other benefits as well.

@tw4l tw4l moved this from Dev In Progress to PR In Review in Webrecorder Projects Nov 30, 2022
@tw4l
Copy link
Member

tw4l commented Nov 30, 2022

Related to #189

@Shrinks99 Shrinks99 added enhancement New feature or request question Further information is requested labels Feb 8, 2023
@tw4l
Copy link
Member

tw4l commented Jan 24, 2024

Now that we're using Brave, this is doable via a browser profile using Brave's build-in features, so closing!

@tw4l tw4l closed this as completed Jan 24, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

3 participants