Skip to content

Commit 1e9e946

Browse files
authored
ci: add Node.js v20 (#3739)
1 parent 79b0f31 commit 1e9e946

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

.github/workflows/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
strategy:
6767
matrix:
6868
os: [ubuntu-latest, windows-latest, macos-latest]
69-
node-version: [14.x, 16.x, 18.x, 19.x]
69+
node-version: [14.x, 16.x, 18.x, 20.x]
7070
shard: ["1/4", "2/4", "3/4", "4/4"]
7171
webpack-version: [latest]
7272
dev-server-version: [latest]

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
"style-loader": "^3.3.1",
8989
"ts-jest": "^29.0.1",
9090
"ts-loader": "^9.3.1",
91-
"ts-node": "^10.8.0",
91+
"ts-node": "^10.9.1",
9292
"typescript": "^5.0.4",
9393
"webpack": "^5.72.0",
9494
"webpack-bundle-analyzer": "^4.5.0",
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
{
2-
"type": "module"
2+
"type": "module",
3+
"engines": {
4+
"node": ">=14.15.0"
5+
}
36
}

test/build/config-format/typescript-esnext/typescript.test.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,18 @@ describe("webpack cli", () => {
1313
return;
1414
}
1515

16+
const env = { ...process.env };
17+
18+
if (majorNodeVersion >= 20) {
19+
// Node.js 20+ change logic, so we need to force esm config loading for test purposes
20+
env.WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG = true;
21+
}
22+
1623
const { exitCode, stderr, stdout } = await run(__dirname, ["-c", "./webpack.config.ts"], {
17-
nodeOptions: ["--loader=ts-node/esm"],
24+
nodeOptions: ["--experimental-loader=ts-node/esm"],
25+
env,
1826
});
27+
1928
expect(stderr).not.toBeFalsy(); // Deprecation warning logs on stderr
2029
expect(stdout).toBeTruthy();
2130
expect(exitCode).toBe(0);

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9700,7 +9700,7 @@ ts-loader@^9.3.1:
97009700
micromatch "^4.0.0"
97019701
semver "^7.3.4"
97029702

9703-
ts-node@^10.8.0, ts-node@^10.8.1:
9703+
ts-node@^10.8.1, ts-node@^10.9.1:
97049704
version "10.9.1"
97059705
resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.9.1.tgz#e73de9102958af9e1f0b168a6ff320e25adcff4b"
97069706
integrity sha512-NtVysVPkxxrwFGUUxGYhfux8k78pQB3JqYBXlLRZgdGUqTO5wU/UyHop5p70iEbGhB7q5KmiZiU0Y3KlJrScEw==

0 commit comments

Comments
 (0)