Use pointer references to reduce copying.

Author: Jeremy Torres

nefparser.go

@@ -54,7 +54,6 @@ type nefHeader struct {
 // NEF-specific information: http://lclevy.free.fr/nef/
 // TIFF specification: http://partners.adobe.com/public/developer/en/tiff/TIFF6.pdf
 type NefParser struct {
-	//	HostIsLittleEndian bool
 	*rawParser
 }
 

rawparser.go

@@ -114,24 +114,24 @@ func (r rawParser) IsHostLittleEndian() bool {
 // lower-case file extension of the raw file type;
 // the value is the pointer to the RawParser implementation.
 type RawParsers struct {
-	parserMap map[string]RawParser
+	parserMap map[string]*RawParser
 }
 
 // NewRawParsers creates an instance of RawParsers.
 func NewRawParsers() *RawParsers {
 	p := new(RawParsers)
-	p.parserMap = make(map[string]RawParser)
+	p.parserMap = make(map[string]*RawParser)
 	return p
 }
 
 // Register maps the implementation of the RawParser
 // interface to the key.
-func (p *RawParsers) Register(key string, parser RawParser) {
+func (p *RawParsers) Register(key string, parser *RawParser) {
 	p.parserMap[key] = parser
 }
 
 // GetParser returns a RawParser for a given raw file type or nil if not found.
-func (p RawParsers) GetParser(key string) RawParser {
+func (p RawParsers) GetParser(key string) *RawParser {
 	return p.parserMap[key]
 }
 

rawparser_test.go

@@ -57,7 +57,7 @@ func TestRawParsers(t *testing.T) {
 	if nefparser == nil || key != NefParserKey {
 		t.Fail()
 	}
-	rp.Register(NefParserKey, nefparser)
+	rp.Register(NefParserKey, &nefparser)
 
 	// delete parser
 	rp.DeleteParser(NefParserKey)
@@ -67,7 +67,7 @@ func TestRawParsers(t *testing.T) {
 	if cr2parser == nil || key != Cr2ParserKey {
 		t.Fail()
 	}
-	rp.Register(Cr2ParserKey, cr2parser)
+	rp.Register(Cr2ParserKey, &cr2parser)
 
 	// delete parser
 	rp.DeleteParser(Cr2ParserKey)