-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split some URL tests into separate files to allow for better ShadowRealm coverage #904
Comments
@hayatoito could you review this change for Chromium? |
I don't disagree, but splitting URL tests into separate files requires a bunch of expectation files rebase in Chromium. It might be better to plan who will work on that before actually doing it so that we don't upset Chromium. |
Hopefully that wouldn't be too big in scope; maybe similar to https://github.com/web-platform-tests/wpt-metadata/pull/6930/files? |
URL is no longer an active focus area in 2025, and the dashboard for this year doesn't include a table for previous focus areas. So, I think signoff from Interop is not needed anymore for this change, but coordinating here could still be useful. cc @valenting |
Closing this issue as the URL focus area is not carried over into 2025 |
Test List
https://wpt.fyi/results/url?sha=f382c0ce93&max-count=2&product=chrome&product=firefox&product=safari&view=interop&q=IdnaTestV2.any.html%20or%20IdnaTestV2.window.html%20or%20urlencoded-parser.any.html%20or%20urlencoded-parser.any.worker.html%20or%20urlencoded-parser-request-response.any.html%20or%20failure.html%20or%20url-constructor-base-failure.any.html
Rationale
As part of the TC39 ShadowRealm proposal we are trying to increase WPT coverage for the various Web APIs exposed in ShadowRealm. This includes running existing tests for APIs such as
URL
in ShadowRealm scopes. However, in order to run as many test files as possible in ShadowRealm scopes, it's necessary to split some of the files that previously contained a mix of tests both suitable and unsuitable for executing in ShadowRealm scopes. See web-platform-tests/wpt#41985 for more details.Here are the splits and renames made in that PR that are relevant to Interop:
Concretely, we propose to add the following tests to the Interop 2023 URL label:
and remove:
(See web-platform-tests/wpt-metadata#6930 for how this would be implemented in wpt-metadata.)
Because subtests have different weights in the Interop score depending on how many other subtests there are in the file, this has an effect on the scores, although it is small. Here is a wpt.fyi link (courtesy of @gsnedders) that I believe shows the effect on the scores. From the numbers there:
The text was updated successfully, but these errors were encountered: