Skip to content

Include css.properties.text-wrap-style.pretty in text-wrap-pretty feature? #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elchi3 opened this issue Apr 22, 2025 · 3 comments · May be fixed by #2891
Open

Include css.properties.text-wrap-style.pretty in text-wrap-pretty feature? #2886

Elchi3 opened this issue Apr 22, 2025 · 3 comments · May be fixed by #2891
Labels
feature definition Creating or defining new features or groups of features.

Comments

@Elchi3
Copy link
Collaborator

Elchi3 commented Apr 22, 2025

The web-feature "text-wrap-pretty" currently consists of the BCD key css.properties.text-wrap.pretty and css.properties.text-wrap-style.pretty is not included. Should it be?

@jensimmons
Copy link

jensimmons commented Apr 22, 2025

Chrome didn't support text-wrap-style for a while, even after it did support text-wrap. Their support came later. I don't know what BCD keys do, or what "grouped to a feature" means... but just FYI. The support matrix is not identical.

@jamesnw
Copy link
Collaborator

jamesnw commented Apr 23, 2025

I think that css.properties.text-wrap-style.pretty should be part of the text-wrap-pretty feature. This will make text-wrap-style Baseline Low, which makes sense to me.

@ddbeck ddbeck linked a pull request Apr 23, 2025 that will close this issue
@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Apr 23, 2025
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 23, 2025

Resolving #1173 is necessary to allow the key to appear in both text-wrap-pretty and text-wrap-style, but otherwise I agree—this is the right thing to do. I've opened #2891 to do this, though I'd like to double check with the MDN team before merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants