Skip to content

Too many text-wrap features #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
foolip opened this issue Jan 16, 2025 · 3 comments · May be fixed by #2900
Open

Too many text-wrap features #2543

foolip opened this issue Jan 16, 2025 · 3 comments · May be fixed by #2900
Labels
feature definition Creating or defining new features or groups of features.

Comments

@foolip
Copy link
Collaborator

foolip commented Jan 16, 2025

There are 7 features related to text-wrap:
https://webstatus.dev/?q=text-wrap

I think these are inarguably worth describing as standalone features, with distinct use cases:

  • text-wrap: balance
  • text-wrap: pretty
  • text-wrap: stable

I don't think these properties without a value should be features if we keep the more specific features like text-wrap: balance:

  • text-wrap
  • text-wrap-mode
  • text-wrap-style

I'm not totally sure about text-wrap: nowrap.

At some point in the future these features might all just merge into a single text-wrap feature, but not right now I think.

cc @lilles who pointed this situation out to me.
@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Jan 16, 2025
@jamesnw
Copy link
Collaborator

jamesnw commented Jan 21, 2025

I'm not opposed to combining these. My memory is we settled on this feature set based on the support story over the developer story, but it's definitely not a cohesive set.

@foolip foolip mentioned this issue Apr 25, 2025
Open
@foolip
Copy link
Collaborator Author

foolip commented Apr 25, 2025

Since I filed this issue I learned from @kojiishi that text-wrap: stable isn't actually a new capability, but just the default behavior in most browsers given a name. So I don't think that deserves its own feature, only text-wrap: balance and text-wrap: pretty do, in addition to a text-wrap feature for everything else.

My hope is that eventually we would fold all of it into text-wrap, when enough time has passed and we have ways to represent "feature evolution" of that sort.

foolip added a commit to foolip/web-features that referenced this issue Apr 25, 2025
@foolip
Reduce the number of text-wrap features to just 3
f5b6d75 
Only `text-wrap: balance` and `text-wrap: pretty` are significant new
features, let everything elese be covered by the generic `text-wrap`
feature.

This changes the Baseline date of `text-wrap` a little, but it's still
in 2024 and so it doesn't seem worth trying to pin it to the earlier
date by trimming the `compute_from` list in a way that wouldn't match
the feature decription.

Fixes web-platform-dx#2543.
@foolip foolip linked a pull request Apr 25, 2025 that will close this issue
Open
@foolip
Copy link
Collaborator Author

foolip commented Apr 25, 2025

I've sent #2900 with what I think we should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce the number of text-wrap features to just 3 foolip/web-features
3 participants
@ddbeck @jamesnw @foolip