Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking a complement set operation flips the booleans on the masked area #378

Closed
jeremyreffin opened this issue Jun 5, 2024 · 1 comment · Fixed by #379
Closed

Taking a complement set operation flips the booleans on the masked area #378

jeremyreffin opened this issue Jun 5, 2024 · 1 comment · Fixed by #379
Assignees
Labels
bug Something isn't working

Comments

@jeremyreffin
Copy link

Describe the bug
If you have chosen a shape extent (e.g. Wealden District Council) then the areas outside the extent should always be excluded. However the Complement set operation flips the bits in the masked out area.

To Reproduce
Steps to reproduce the behavior:

  1. Choose an extent like WDC
  2. Take a boolean feature from some input (e.g. coniferous woodland)
  3. Apply the Complement operation
  4. The result will show TRUE bits for the area outside the extent

Expected behavior
Area outside the extent should always be ignored

Screenshots
Attached
Screenshot 2024-06-05 at 11 12 52

@jeremyreffin jeremyreffin added the bug Something isn't working label Jun 5, 2024
@paulthatjazz paulthatjazz self-assigned this Jun 5, 2024
@paulthatjazz paulthatjazz linked a pull request Jun 5, 2024 that will close this issue
@paulthatjazz
Copy link
Contributor

Attached PR should deal with the issue.

Creating a new issue to refactor the performOperation worker to incorporate the masks when we have more time to deal with tech debt. This should consider the mask within the operation instead of applying the mask after to improve efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants