Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GalleryHelper.java missing permissions check #76

Open
Skyler-Altol opened this issue Mar 23, 2019 · 2 comments
Open

GalleryHelper.java missing permissions check #76

Skyler-Altol opened this issue Mar 23, 2019 · 2 comments
Labels

Comments

@Skyler-Altol
Copy link

Scenario:

Build an app that involves uploading a locally stored image to IBM's Watson for image analysis. Use the GalleryHelper to assist with this process. Attempt to run the app. You will find that you run into permissions errors because GalleryHelper is missing a permissions check for READ_EXTERNAL_STORAGE. This should be an easy fix, CameraHelper has a permissions check method in it, and this is quite similar.

@lpatino10
Copy link
Contributor

Hey @Skyler-Altol, thanks for filing this issue. I'm a bit busy with some other release stuff at the moment, but I'll try to take a look at this next week. In the meantime, if you think you might have a quick fix for the problem, feel free to make a PR and I'll happily review!

@lpatino10 lpatino10 added the bug label Mar 26, 2019
@Skyler-Altol
Copy link
Author

I was able to make a fix for the purposes of my university assignment, but I will not publish said fix here because it is probably one of the most hacky things I've ever written, and should never be seen in a production environment. I too am also busy until next week, but if I get a chance, I'll do a further deep dive into Android permissions and how to appropriately handle asking for permissions from a user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants