Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPropertyType() needs a rewrite? #456

Closed
lukewarlow opened this issue Feb 26, 2024 · 0 comments · Fixed by #457
Closed

getPropertyType() needs a rewrite? #456

lukewarlow opened this issue Feb 26, 2024 · 0 comments · Fixed by #457
Milestone
v1

Comments

@lukewarlow
Copy link
Member

Like #423 but for getPropertyType().

Neither getPropertyType() nor getAttributeType() are actually implemented as specced they both in reality use a hardcoded "map" it would be better to spec both of these as actually implemented. This will help future implementators but also help drive the point that if a new sink is added to the spec it needs adding to these maps too.
@lukewarlow lukewarlow added this to the v1 milestone Feb 26, 2024
@lukewarlow lukewarlow changed the title getPropertyType() needs a rewrite()? getPropertyType() needs a rewrite? Feb 26, 2024
@lukewarlow lukewarlow mentioned this issue Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Rewrite metadata functions lukewarlow/trusted-types
1 participant
@lukewarlow