Skip to content

Conversation

@teslazonda
Copy link
Contributor

@teslazonda teslazonda commented Nov 19, 2025

Change Summary

Edited content in the docs/operation directory to align with the Microsoft Writing Style Guide

  • boot-options.rst
  • information.rst
  • upgrade-recovery.rst
  • raid.rst
  • password-recovery.rst

Related Task(s)

  • TBD

Related PR(s)

Backport

Checklist:

@teslazonda teslazonda changed the title Proofread docs in operation directory Proofread docs in the operation directory Nov 19, 2025
@teslazonda teslazonda changed the title Proofread docs in the operation directory Proofread docs in the /operation directory Nov 19, 2025
recent Linux distributions.

For additional details you can refer to https://vyos.dev/T2490.
For details, see https://vyos.dev/T2490.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was resolved in 2020. Is the above content still relevant?

.. note:: If a device is unplugged and re-plugged it will receive a new
Port, Dev, If identification.
.. note:: If a device is unplugged and plugged in again, it is assigned a new
``Port``, ``Dev``, and ``If``.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do Dev and If stand for?

@teslazonda teslazonda marked this pull request as ready for review November 27, 2025 22:19
#################

Using the console, restart the VyOS router. The GRUB menu appears.
Select the relevant option from the GRUB menu and press Enter.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this password recovery flow still accurate?

Comment on lines +47 to 48
Standard installation on a single disk
------------------------------
Copy link
Member

@sever-sever sever-sever Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be

Standard installation on a single disk 
--------------------------------------

Copilot finished reviewing on behalf of sever-sever November 28, 2025 12:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR proofreads and improves documentation in the /docs/operation directory to align with the Microsoft Writing Style Guide. The changes focus on improving clarity, consistency, and readability across five operation documentation files while updating the last proofread dates to November 2025.

  • Standardized UI element formatting using bold text (e.g., Yes, No, Enter)
  • Improved sentence structure and readability throughout the documentation
  • Updated terminology for consistency (e.g., "RAID-1" to "RAID 1")
  • Enhanced descriptions with clearer, more concise language
  • Added proper section cross-references and updated metadata

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
docs/operation/upgrade-recovery.rst Improved readability of upgrade recovery feature documentation, clarified timeout behavior, and wrapped long lines for better formatting
docs/operation/raid.rst Extensive revisions to RAID 1 documentation including terminology standardization, UI element formatting, section header updates, and improved procedural instructions
docs/operation/password-recovery.rst Minor improvements to password recovery instructions with updated UI element formatting and clearer action descriptions
docs/operation/information.rst Enhanced system information command documentation with updated examples, improved USB device descriptions, and added VyOS 1.5 release train information
docs/operation/boot-options.rst Simplified boot option instructions with clearer warnings and more concise procedural steps
docs/_locale/{uk,pt,ja,es,de}/operation.pot Updated translation files to reflect changes in UI element formatting from quoted text to bold text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

VyOS provides several kernel command-line options to modify the normal boot
process.
To add an option, select the desired image in the GRUB menu at load time.
Type **e** to edit the first line, then type **Ctrl+x** to boot.
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent keyboard key notation. Line 17 uses "Ctrl+x" with a plus sign, but this is inconsistent with standard documentation practices. The Microsoft Writing Style Guide recommends using "Ctrl+X" (with capital X) for keyboard shortcuts. Additionally, verify consistency with other keyboard notations in the document (line 17 uses "e" which should also be consistent).

Suggested change
Type **e** to edit the first line, then type **Ctrl+x** to boot.
Type **e** to edit the first line, then type **Ctrl+X** to boot.

Copilot uses AI. Check for mistakes.

Installation Implications
Installation implications
=========================
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent section header capitalization. According to the Microsoft Writing Style Guide, sentence-style capitalization should be used for headings. Change "Installation implications" to match the capitalization style used in other section headers like "Configuration".

Suggested change
=========================
========================

Copilot uses AI. Check for mistakes.
=============

Single disk, install as normal
Standard installation on a single disk
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent section header capitalization. The header should use title case for consistency with other sections. Change "Standard installation on a single disk" to "Standard Installation on a Single Disk".

Suggested change
Standard installation on a single disk
Standard Installation on a Single Disk

Copilot uses AI. Check for mistakes.
* If you do not want to configure RAID 1 mirroring, enter **No** at the prompt.

Empty 2+ Disk
Empty 2+ disk
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent section header capitalization. The header should use title case for consistency with other sections. Change "Empty 2+ disk" to "Empty 2+ Disk" to match the capitalization style.

Suggested change
Empty 2+ disk
Empty 2+ Disk

Copilot uses AI. Check for mistakes.


Present RAID-1
Preexisting RAID 1 configuration
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent section header capitalization. The header should use title case for consistency with other sections. Change "Preexisting RAID 1 configuration" to "Preexisting RAID 1 Configuration".

Suggested change
Preexisting RAID 1 configuration
Preexisting RAID 1 Configuration

Copilot uses AI. Check for mistakes.
Comment on lines +89 to +90
4. Enter **Yes** at the prompt to retain the current VyOS configuration
Enter **No** to delete the current VyOS configuration.
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence structure is awkward and incomplete. Line 90 starts a new sentence but doesn't complete the thought clearly. Consider revising to: "4. Enter Yes at the prompt to retain the current VyOS configuration, or enter No to delete the current VyOS configuration."

Suggested change
4. Enter **Yes** at the prompt to retain the current VyOS configuration
Enter **No** to delete the current VyOS configuration.
4. Enter **Yes** at the prompt to retain the current VyOS configuration, or enter **No** to delete the current VyOS configuration.

Copilot uses AI. Check for mistakes.
Comment on lines +156 to +159
where ``RAID-1-device`` is the name of the RAID 1 device. For example,
``md0`` and
``disk-partition`` is the name of the failed disk partition. For example,
``sdb2``.
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward line break. The text "For example, md0 and" should continue on the same line as the description. Consider reformatting to: "where RAID-1-device is the name of the RAID 1 device (for example, md0) and disk-partition is the name of the failed disk partition (for example, sdb2)."

Suggested change
where ``RAID-1-device`` is the name of the RAID 1 device. For example,
``md0`` and
``disk-partition`` is the name of the failed disk partition. For example,
``sdb2``.
where ``RAID-1-device`` is the name of the RAID 1 device (for example, ``md0``) and ``disk-partition`` is the name of the failed disk partition (for example, ``sdb2``).

Copilot uses AI. Check for mistakes.
Comment on lines +177 to +180
where ``RAID-1-device`` is the name of the RAID 1 device. For example,
``md0`` and
``disk-partition`` is the name of the replacement disk partition.
For example, ``sdb2``.
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward line break. The formatting is inconsistent with examples spread across multiple lines. Consider reformatting to: "where RAID-1-device is the name of the RAID 1 device (for example, md0) and disk-partition is the name of the replacement disk partition (for example, sdb2)."

Suggested change
where ``RAID-1-device`` is the name of the RAID 1 device. For example,
``md0`` and
``disk-partition`` is the name of the replacement disk partition.
For example, ``sdb2``.
where ``RAID-1-device`` is the name of the RAID 1 device (for example, ``md0``) and ``disk-partition`` is the name of the replacement disk partition (for example, ``sdb2``).

Copilot uses AI. Check for mistakes.
Comment on lines +22 to +24
In the past, serial interfaces were defined as ``ttySx`` and ``ttyUSBx`` where
``x``
was the instance number. However, the mapping of USB-based serial interfaces
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Awkward line break in the middle of a sentence. Line 23 breaks at "x" which creates a confusing read. Consider keeping "where x was the instance number" on the same line for better readability.

Suggested change
In the past, serial interfaces were defined as ``ttySx`` and ``ttyUSBx`` where
``x``
was the instance number. However, the mapping of USB-based serial interfaces
In the past, serial interfaces were defined as ``ttySx`` and ``ttyUSBx`` where ``x`` was the instance number. However, the mapping of USB-based serial interfaces

Copilot uses AI. Check for mistakes.
interface is now directly identified by the USB root bridge and bus it connects
to. This somehow mimics the new network interface definitions we see in recent
Linux distributions.
To address this issue, and because of many low-cost USB-to-serial converters
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issue: "because of many" should be "because many". Remove "of" for correct grammar.

Suggested change
To address this issue, and because of many low-cost USB-to-serial converters
To address this issue, and because many low-cost USB-to-serial converters

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants