-
Notifications
You must be signed in to change notification settings - Fork 395
T8011: VPP fix log duplication in systemd journal #4882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Set the standard output/error to null to avoid log duplication. Starting the service as "nodaemon" seems cause of this behavior.
|
👍 |
|
CI integration 👍 passed! Details
|
c-po
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplicate logs to syslog/journal.
As vpp runs supervised it captures both internal syslog glibc calls and stdout. Omit the latter beeing sent to syslog/journal, too.
|
Are we absolutely certain that no logs are printed only to stdout/stderr and not forwarded to syslog? |
@zdc I do not see any way to say exactly. I see the log duplication and provided minimal set of commands to reproduce. I prefer this format, as another format with |
zdc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is not an ideal solution from my perspective, I think we can accept it.
Change summary
Set the standard output/error to
nullto avoid log duplication.Starting the service as "nodaemon" seems cause of this behavior.
Fixes VPP log duplication
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Before the fix, we see duplicate log entries:
After the fix we do not see log duplication:
Checklist: