Skip to content

Conversation

@sever-sever
Copy link
Member

Change summary

Set the standard output/error to null to avoid log duplication.
Starting the service as "nodaemon" seems cause of this behavior.
Fixes VPP log duplication

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

set vpp settings interface eth1 driver 'dpdk'
set vpp settings unix poll-sleep-usec '2222'

Before the fix, we see duplicate log entries:

vyos@vyos# sudo journalctl -b --unit vpp | tee
Nov 19 14:46:07 vyos systemd[1]: Starting vector packet processing engine...
Nov 19 14:46:07 vyos systemd[1]: Started vector packet processing engine.
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: adl plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: adl plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: arping plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: arping plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: cdp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: cdp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: ct6 plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: ct6 plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: dhcp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: dhcp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: dns plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: dns plugin not loaded...
...

After the fix we do not see log duplication:

Dec 01 15:30:50 r14 systemd[1]: Starting vector packet processing engine...
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: adl plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: arping plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: cdp plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: ct6 plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: dhcp plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: dns plugin not loaded...
...

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Set the standard output/error to null to avoid log duplication.
Starting the service as "nodaemon" seems cause of this behavior.
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever added the bp/circinus Create automatic backport for circinus label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid duplicate logs to syslog/journal.

As vpp runs supervised it captures both internal syslog glibc calls and stdout. Omit the latter beeing sent to syslog/journal, too.

@zdc
Copy link
Contributor

zdc commented Dec 2, 2025

Are we absolutely certain that no logs are printed only to stdout/stderr and not forwarded to syslog?

@sever-sever
Copy link
Member Author

sever-sever commented Dec 5, 2025

Are we absolutely certain that no logs are printed only to stdout/stderr and not forwarded to syslog?

@zdc I do not see any way to say exactly. I see the log duplication and provided minimal set of commands to reproduce.
Are you ok with this PR?

I prefer this format, as another format with nosyslog option looks ugly

vyos@r14:~$  sudo journalctl -b --unit vpp | tee
Dec 02 14:17:02 r14 systemd[1]: Starting vector packet processing engine...
Dec 02 14:17:03 r14 vpp[3965]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Dec 02 14:17:03 r14 vpp[3965]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Dec 02 14:17:03 r14 vpp[3965]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Dec 02 14:17:03 r14 vpp[3965]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Dec 02 14:17:03 r14 vpp[3965]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Dec 02 14:17:03 r14 vpp[3965]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: adl plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: arping plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: cdp plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: ct6 plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: dhcp plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: dns plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: gtpu plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: http_static plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: idpf plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: ikev2 plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: pot_vat_plugin_register: pot plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: ip_session_redirect plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: l2tp plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: lb plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register_gpe: lisp_gpe plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: lldp plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: mactime plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: mdata plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: memif plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: nsh plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: nsim plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: rdma plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: sr_mpls plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: stn plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: tls_openssl plugin not loaded...
Dec 02 14:17:03 r14 vpp[3965]: vat-plug/load      [error ]: vat_plugin_register: vrrp plugin not loaded...
Dec 02 14:17:05 r14 systemd[1]: Started vector packet processing engine.
Dec 02 14:17:05 r14 vpp[3965]: clib_c11_violation: s1 NULL
Dec 02 14:17:05 r14 vpp[3965]: clib_c11_violation: s2 NULL
...

Copy link
Contributor

@zdc zdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is not an ideal solution from my perspective, I think we can accept it.

@sever-sever sever-sever merged commit 45e17ed into vyos:current Dec 9, 2025
19 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bp/circinus Create automatic backport for circinus current mirror-completed

Development

Successfully merging this pull request may close these issues.

4 participants