Skip to content

Commit 7a1eb52

Browse files
committed
remove logger from default build
1 parent b981e2d commit 7a1eb52

File tree

6 files changed

+23
-20
lines changed

6 files changed

+23
-20
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ node_modules
33
TODO.md
44
lib
55
docs/_book
6+
logger.js

build/build.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,16 @@ rollup.rollup({
1919
plugins: [babel()]
2020
})
2121
.then(function (bundle) {
22-
return write('dist/vuex.js', bundle.generate({
22+
var code = bundle.generate({
2323
format: 'umd',
2424
banner: banner,
2525
moduleName: 'Vuex'
26-
}).code)
27-
})
28-
.then(function () {
29-
// Standalone Production Build
30-
return rollup.rollup({
31-
entry: 'src/index.js',
32-
plugins: [babel()]
26+
}).code
27+
return write('dist/vuex.js', code).then(function () {
28+
return code
3329
})
3430
})
35-
.then(function (bundle) {
36-
var code = bundle.generate({
37-
format: 'umd',
38-
moduleName: 'Vuex'
39-
}).code
31+
.then(function (code) {
4032
var minified = banner + '\n' + uglify.minify(code, {
4133
fromString: true,
4234
output: {
@@ -45,6 +37,16 @@ rollup.rollup({
4537
}).code
4638
return write('dist/vuex.min.js', minified)
4739
})
40+
.then(function () {
41+
return rollup.rollup({
42+
entry: 'src/middlewares/logger.js',
43+
plugins: [babel()]
44+
}).then(function (bundle) {
45+
return write('logger.js', bundle.generate({
46+
format: 'cjs'
47+
}).code)
48+
})
49+
})
4850
.catch(logError)
4951

5052
function write (dest, code) {

examples/chat/vuex/store.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import Vue from 'vue'
22
import Vuex from '../../../src'
33
import mutations from './mutations'
4+
import createLogger from '../../../src/middlewares/logger'
45

56
Vue.use(Vuex)
67

@@ -33,6 +34,6 @@ export default new Vuex.Store({
3334
},
3435
mutations,
3536
middlewares: process.env.NODE_ENV !== 'production'
36-
? [Vuex.createLogger()]
37+
? [createLogger()]
3738
: []
3839
})

examples/todomvc/vuex/middlewares.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { STORAGE_KEY } from './store'
2-
import Vuex from '../../../src'
2+
import createLogger from '../../../src/middlewares/logger'
33

44
const localStorageMiddleware = {
55
onMutation (mutation, { todos }) {
@@ -8,5 +8,5 @@ const localStorageMiddleware = {
88
}
99

1010
export default process.env.NODE_ENV !== 'production'
11-
? [Vuex.createLogger(), localStorageMiddleware]
11+
? [createLogger(), localStorageMiddleware]
1212
: [localStorageMiddleware]

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
"main": "dist/vuex.js",
66
"files": [
77
"dist",
8-
"src"
8+
"src",
9+
"logger.js"
910
],
1011
"scripts": {
1112
"counter": "cd examples/counter && webpack-dev-server --inline --hot --config ../webpack.shared.config.js",

src/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { mergeObjects, deepClone } from './util'
22
import devtoolMiddleware from './middlewares/devtool'
3-
import createLogger from './middlewares/logger'
43
import override from './override'
54

65
let Vue
@@ -241,6 +240,5 @@ function install (_Vue) {
241240

242241
export default {
243242
Store,
244-
install,
245-
createLogger
243+
install
246244
}

0 commit comments

Comments
 (0)