theme-color meta tag in build index.html not respecting manifest.json theme_color

[lukewiwa]

Version

3.3.0

Reproduction link

https://github.com/lukewiwa/vue-cli-theme-color-bug

Environment info

Environment Info:

  System:
    OS: macOS 10.14.2
    CPU: (4) x64 Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
  Binaries:
    Node: 10.11.0 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 71.0.3578.98
    Firefox: 64.0
    Safari: 12.0.2
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0-beta.1
    @vue/babel-plugin-transform-vue-jsx:  1.0.0-beta.1
    @vue/babel-preset-app:  3.3.0
    @vue/babel-preset-jsx:  1.0.0-beta.1
    @vue/babel-sugar-functional-vue:  1.0.0-beta.1
    @vue/babel-sugar-inject-h:  1.0.0-beta.1
    @vue/babel-sugar-v-model:  1.0.0-beta.1
    @vue/babel-sugar-v-on:  1.0.0-beta.1
    @vue/cli-overlay:  3.3.0
    @vue/cli-plugin-babel: ^3.3.0 => 3.3.0
    @vue/cli-plugin-eslint: ^3.3.0 => 3.3.0
    @vue/cli-plugin-pwa: ^3.3.0 => 3.3.0
    @vue/cli-service: ^3.3.0 => 3.3.0
    @vue/cli-shared-utils:  3.3.0
    @vue/component-compiler-utils:  2.5.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    babel-plugin-transform-vue-jsx:  4.0.1
    eslint-plugin-vue: ^5.0.0 => 5.1.0
    vue: ^2.5.21 => 2.5.21
    vue-eslint-parser:  2.0.3
    vue-hot-reload-api:  2.3.1
    vue-loader:  15.5.1
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.5.21
    vue-template-es2015-compiler:  1.7.0
  npmGlobalPackages:
    @vue/cli: 3.3.0

Steps to reproduce

Run npm run build

the build index.html file in the dist folder contains a which doesn't reflect the color chosen in the maifest.json file.

What is expected?

The theme color option from the manifest.json file should be inserted into the build index.html file in the meta field "theme-color"

What is actually happening?

The default Vue color theme is injected into the build index.html file

---

I launched an app using vue cli on a firebase hosting instance and was frankly a little annoyed that on android the theme color was the vue theme color when I had explicitly set it in the manifest.json file.

[lukewiwa]

I understand the option resides in the vue.config.js file. I would suggest one is automatically created when the pwa plugin is installed for better discoverability.