Skip to content

Commit b9cce99

Browse files
committed
test: do not hard-code major version number in test
1 parent 04297fd commit b9cce99

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

packages/@vue/cli-service/__tests__/Service.spec.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ jest.mock('vue-cli-plugin-foo', () => () => {}, { virtual: true })
33

44
const fs = require('fs')
55
const path = require('path')
6+
const { semver } = require('@vue/cli-shared-utils')
67
const Service = require('../lib/Service')
78

89
const mockPkg = json => {
@@ -159,8 +160,9 @@ test('api: assertVersion', () => {
159160
const plugin = {
160161
id: 'test-assertVersion',
161162
apply: api => {
162-
expect(() => api.assertVersion(4)).not.toThrow()
163-
expect(() => api.assertVersion('^4.0.0-0')).not.toThrow()
163+
const majorVersionNumber = semver.major(api.version)
164+
expect(() => api.assertVersion(majorVersionNumber)).not.toThrow()
165+
expect(() => api.assertVersion(`^${majorVersionNumber}.0.0-0`)).not.toThrow()
164166
// expect(() => api.assertVersion('>= 4')).not.toThrow()
165167

166168
expect(() => api.assertVersion(4.1)).toThrow('Expected string or integer value')

0 commit comments

Comments
 (0)