Skip to content

Commit 9f5dda4

Browse files
author
Guillaume Chau
committed
fix(ui): wwebpack dashboard performance improvements
1 parent f486d7e commit 9f5dda4

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

packages/@vue/cli-ui-addon-webpack/src/components/AssetListItem.vue

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
<template>
1+
<template functional>
22
<div
33
:class="{
4-
big: asset.big,
5-
secondary: asset.secondary
4+
big: props.asset.big,
5+
secondary: props.asset.secondary
66
}"
77
class="asset-list-item"
88
>
99
<div class="content">
10-
<div class="info name">{{ asset.name }}</div>
11-
<div class="info size">{{ asset.size | size('B') }}</div>
12-
<div class="info speed global">{{ asset.speeds.global.totalDownloadTime | round(100) }}s</div>
13-
<div class="info speed 3gs">{{ asset.speeds['3gs'].totalDownloadTime | round(100) }}s</div>
14-
<div class="info speed 3gf">{{ asset.speeds['3gf'].totalDownloadTime | round(100) }}s</div>
10+
<div class="info name">{{ props.asset.name }}</div>
11+
<div class="info size">{{ props.asset.size | size('B') }}</div>
12+
<div class="info speed global">{{ props.asset.speeds.global.totalDownloadTime | round(100) }}s</div>
13+
<div class="info speed 3gs">{{ props.asset.speeds['3gs'].totalDownloadTime | round(100) }}s</div>
14+
<div class="info speed 3gf">{{ props.asset.speeds['3gf'].totalDownloadTime | round(100) }}s</div>
1515
<div class="info warning">
1616
<VueIcon
17-
v-if="!asset.secondary && asset.big"
17+
v-if="!props.asset.secondary && props.asset.big"
1818
icon="warning"
1919
class="icon"
20-
v-tooltip="$t('vue-webpack.dashboard.asset-list.size-warning')"
20+
v-tooltip="parent.$t('vue-webpack.dashboard.asset-list.size-warning')"
2121
/>
2222
</div>
2323
</div>

packages/@vue/cli-ui-addon-webpack/src/components/ModuleListItem.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
<template>
1+
<template functional>
22
<div class="module-list-item">
33
<div class="content">
4-
<div class="info name">{{ module.name }}</div>
5-
<div class="info size">{{ module.size | size('B') }}</div>
4+
<div class="info name">{{ props.module.name }}</div>
5+
<div class="info size">{{ props.module.size | size('B') }}</div>
66
<div class="info">
7-
<VueLoadingBar :value="module.ratio" class="primary"/>
7+
<VueLoadingBar :value="props.module.ratio" class="primary"/>
88
</div>
99
</div>
1010
</div>

0 commit comments

Comments
 (0)