fix: disable no-undef as recommended (#51)

LinusBorg · web-flow · commit 4116ac82be10 · 2023-04-25T16:17:14.000+08:00
diff --git a/index.js b/index.js
@@ -32,6 +32,9 @@ module.exports = {
         // The core 'no-unused-vars' rules (in the eslint:recommeded ruleset)
         // does not work with type definitions
         'no-unused-vars': 'off',
+        // TS already checks for that, and Typescript-Eslint recommends to disable it
+        // https://typescript-eslint.io/linting/troubleshooting#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
+        'no-undef': 'off',
         '@typescript-eslint/no-unused-vars': 'warn'
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ module.exports = {`
`32`	`32`	`// The core 'no-unused-vars' rules (in the eslint:recommeded ruleset)`
`33`	`33`	`// does not work with type definitions`
`34`	`34`	`'no-unused-vars': 'off',`
	`35`	`+ // TS already checks for that, and Typescript-Eslint recommends to disable it`
	`36`	`+ // https://typescript-eslint.io/linting/troubleshooting#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors`
	`37`	`+ 'no-undef': 'off',`
`35`	`38`	`'@typescript-eslint/no-unused-vars': 'warn'`
`36`	`39`	`}`
`37`	`40`	`}`