Skip to content

Commit 928ab51

Browse files
committed
Remove SubscriberFlags.Notified
1 parent ba00468 commit 928ab51

File tree

1 file changed

+20
-7
lines changed

1 file changed

+20
-7
lines changed

packages/reactivity/src/system.ts

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ export enum SubscriberFlags {
3838
InnerEffectsPending = 1 << 2,
3939
ToCheckDirty = 1 << 3,
4040
Dirty = 1 << 4,
41-
Notified = SubscriberFlags.InnerEffectsPending |
42-
SubscriberFlags.ToCheckDirty |
43-
SubscriberFlags.Dirty,
4441
}
4542

4643
let batchDepth = 0
@@ -151,14 +148,21 @@ export function propagate(link: Link): void {
151148
subFlags &
152149
(SubscriberFlags.Tracking |
153150
SubscriberFlags.Recursed |
154-
SubscriberFlags.Notified)
151+
SubscriberFlags.InnerEffectsPending |
152+
SubscriberFlags.ToCheckDirty |
153+
SubscriberFlags.Dirty)
155154
) &&
156155
((sub.flags = subFlags | targetFlag), true)) ||
157156
(subFlags & SubscriberFlags.Recursed &&
158157
!(subFlags & SubscriberFlags.Tracking) &&
159158
((sub.flags = (subFlags & ~SubscriberFlags.Recursed) | targetFlag),
160159
true)) ||
161-
(!(subFlags & SubscriberFlags.Notified) &&
160+
(!(
161+
subFlags &
162+
(SubscriberFlags.InnerEffectsPending |
163+
SubscriberFlags.ToCheckDirty |
164+
SubscriberFlags.Dirty)
165+
) &&
162166
isValidLink(link, sub) &&
163167
((sub.flags = subFlags | SubscriberFlags.Recursed | targetFlag),
164168
(sub as Dependency).subs !== undefined))
@@ -190,7 +194,10 @@ export function propagate(link: Link): void {
190194
} else if (
191195
!(subFlags & (SubscriberFlags.Tracking | targetFlag)) ||
192196
(!(subFlags & targetFlag) &&
193-
subFlags & SubscriberFlags.Notified &&
197+
subFlags &
198+
(SubscriberFlags.InnerEffectsPending |
199+
SubscriberFlags.ToCheckDirty |
200+
SubscriberFlags.Dirty) &&
194201
isValidLink(link, sub))
195202
) {
196203
sub.flags = subFlags | targetFlag
@@ -338,7 +345,13 @@ export function checkDirty(link: Link): boolean {
338345
export function startTrack(sub: Subscriber): void {
339346
sub.depsTail = undefined
340347
sub.flags =
341-
(sub.flags & ~(SubscriberFlags.Recursed | SubscriberFlags.Notified)) |
348+
(sub.flags &
349+
~(
350+
SubscriberFlags.Recursed |
351+
SubscriberFlags.InnerEffectsPending |
352+
SubscriberFlags.ToCheckDirty |
353+
SubscriberFlags.Dirty
354+
)) |
342355
SubscriberFlags.Tracking
343356
}
344357

0 commit comments

Comments
 (0)