Skip to content

Commit f37880b

Browse files
authored
Merge pull request #77 from mwcraig/fix-qt-error
Fix logic in check for python version
2 parents e6b5105 + a7b4ed4 commit f37880b

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ var/
2828

2929
!vpython/lib
3030

31+
# Notebook stuff
32+
.ipynb_checkpoints
33+
3134
# PyInstaller
3235
# Usually these files are written by a python script from a template
3336
# before PyInstaller builds the exe, so as to inject date/other infos into it.

Demos_no_notebook/qt.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
from vpython import *
2+
set_browser(type='pyqt')
3+
b = box()

vpython/no_notebook.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def onClose(self, wasClean, code, reason):
249249
raise RuntimeError('The pyqt browser cannot be used on Windows. '
250250
'Please use the default browser instead by '
251251
'removing set_browser("pyqt") from your code.')
252-
elif sys.version_info.major == 3 and sys.version_info.minor >= 7:
252+
elif sys.version_info.major == 3 and sys.version_info.minor >= 8:
253253
raise RuntimeError('The pyqt browser cannot be used on Python 3.8. '
254254
'Please use the default browser instead by '
255255
'removing set_browser("pyqt") from your code.')

0 commit comments

Comments
 (0)