Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of gratis #5

Open
vporton opened this issue Jun 23, 2017 · 1 comment
Open

Get rid of gratis #5

vporton opened this issue Jun 23, 2017 · 1 comment

Comments

@vporton
Copy link
Owner

vporton commented Jun 23, 2017

We should get rid of gratis in the SubscriptionItem model and instead test for price == 0.
@vporton
Copy link
Owner Author

vporton commented Jun 23, 2017

Note that usually canceling of gratis state happens only through a purchase, while during purchase a new price is set, so old price (even if it would be nonzero) is ignored and so there is no need to store a nonzero price in the case if gratis flag is set.

The conclusion: We do not need both gratis boolean flag and price field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vporton