Skip to content

Commit 66fa47b

Browse files
committed
Limit to known-good setups from acceptance tests
For acceptance testing, we look into metadata.json for supported versions of Puppet and operating systems, and for each combination try to execute the acceptance test suites. However, some combination depend on nonexistent packages, typically for a recent version of Puppet on an old Linux distribution, or with an old version of Puppet on a recent Linux distribution. Instead of letting GitHub compute all possible matrix combinations, rely on puppet_metadata to build the list of supported combinations.
1 parent 04e5522 commit 66fa47b

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

moduleroot/.github/workflows/ci.yml.erb

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ jobs:
1212
runs-on: ubuntu-latest
1313
timeout-minutes: <%= @configs['timeout_minutes'] %>
1414
outputs:
15-
beaker_setfiles: ${{ steps.get-outputs.outputs.beaker_setfiles }}
16-
puppet_major_versions: ${{ steps.get-outputs.outputs.puppet_major_versions }}
1715
puppet_unit_test_matrix: ${{ steps.get-outputs.outputs.puppet_unit_test_matrix }}
16+
github_action_test_matrix: ${{ steps.get-outputs.outputs.github_action_test_matrix }}
1817
env:
1918
BUNDLE_WITHOUT: development:system_tests:release
2019
steps:
@@ -63,8 +62,7 @@ jobs:
6362
strategy:
6463
fail-fast: false
6564
matrix:
66-
setfile: ${{fromJson(needs.setup_matrix.outputs.beaker_setfiles)}}
67-
puppet: ${{fromJson(needs.setup_matrix.outputs.puppet_major_versions)}}
65+
include: ${{fromJson(needs.setup_matrix.outputs.github_action_test_matrix)}}
6866
<%- @configs['beaker_fact_matrix'].each do |option, values| -%>
6967
<%= option %>:
7068
<%- values.each do |value| -%>

0 commit comments

Comments
 (0)