TS fixes (#280)

Author: p-zielinski

.changeset/witty-suns-hunt.md

@@ -0,0 +1,5 @@
+---
+'@voucherify/sdk': patch
+---
+
+TS fixes (VouchersListTransactionsRequestQuery, LoyaltiesListCardTransactionsRequestQuery, ProductCollectionsCreateRequestBody) - backwards compatible

packages/sdk/src/types/Loyalties.ts

@@ -602,6 +602,11 @@ export interface LoyaltiesGetPointsExpirationResponseBody {
 
 export interface LoyaltiesListCardTransactionsRequestQuery {
 	limit?: number
+	starting_after_id?: string
+	order?: 'id' | '-id' // default -id
+	/**
+	 * @deprecated Use starting_after_id
+	 */
 	page?: number
 }
 
@@ -610,6 +615,7 @@ export interface LoyaltiesListCardTransactionsResponseBody {
 	data_ref: 'data'
 	data: LoyaltyCardTransaction[]
 	has_more: boolean
+	more_starting_after?: string
 }
 
 export type LoyaltiesExportCardTransactionsRequestBody = VouchersExportTransactionsRequestBody
@@ -711,13 +717,6 @@ export interface LoyaltiesListCardTransactionsRequestQuery {
 	page?: number
 }
 
-export interface LoyaltiesListCardTransactionsResponseBody {
-	object: 'list'
-	data_ref: 'data'
-	data: LoyaltyCardTransaction[]
-	has_more: boolean
-}
-
 export type LoyaltiesExportCardTransactionsResponseBody = VouchersExportTransactionsResponseBody
 
 export interface LoyaltiesAddOrRemoveCardBalanceRequestBody {

packages/sdk/src/types/ProductCollections.ts

@@ -70,12 +70,18 @@ export interface DynamicProductCollectionBase {
 
 export type ProductCollection = ProductCollectionBase & ProductCollectionIdentity & ProductCollectionSaved
 
-export type Filter = {
-	junction: Junction
-} & Partial<Record<AllowedFiltersKeys, { conditions: Partial<Record<FiltersCondition, unknown>> }>>
+export type Filter = Partial<
+	Record<string, Junction | { conditions: Partial<Record<FiltersCondition, unknown>> }>
+> /*
+junction: Junction;
+'id'| 'name'| 'attributes'| 'source_id'| 'price'| 'image_url'| 'product_id'| 'skus'| 'created_at'| 'updated_at'| 'object' | `metadata.${string}`: { conditions: Partial<Record<FiltersCondition, unknown>> }
+*/
 
 export declare type Junction = 'and' | 'AND' | 'or' | 'OR'
 
+/**
+ * @deprecated
+ */
 export type AllowedFiltersKeys =
 	| 'id'
 	| 'name'

packages/sdk/src/types/Vouchers.ts

@@ -388,6 +388,11 @@ export type VoucherTransactionsExportFields =
 // List transactions
 export interface VouchersListTransactionsRequestQuery {
 	limit?: number
+	starting_after_id?: string
+	order?: 'id' | '-id' // default -id
+	/**
+	 * @deprecated Use starting_after_id
+	 */
 	page?: number
 }
 
@@ -396,6 +401,7 @@ export interface VouchersListTransactionsResponseBody {
 	data_ref: 'data'
 	data: VoucherTransaction[]
 	has_more: boolean
+	more_starting_after?: string
 }
 
 // Export transactions

packages/sdk/test/productCollections.spec.ts

@@ -159,4 +159,12 @@ describe('Product Collections API', () => {
 			} as ProductCollectionsCreateResponseBody),
 		)
 	})
+
+	it('should create AUTO_UPDATE collection based on product metadata', async () => {
+		await client.productCollections.create({
+			name: 'xxx',
+			type: 'AUTO_UPDATE',
+			filter: { junction: 'AND', 'metadata.isAwesome': { conditions: { $is: [true] } } },
+		})
+	})
 })