Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User connected with Google cannot delete his account : the password is unknown #225

Open
Leonard1980 opened this issue Jan 11, 2018 · 1 comment

Comments

@Leonard1980
Copy link

Leonard1980 commented Jan 11, 2018

The user connected with Google for the firs time, registers automatically without a password.
On deleting the account or on changing the password, a password must be provided for those actions to be performed.

If the app generates a random password then it must be provided to the user by email, and if the password is empty for this user, then the views for those specific actions must let the "google user" to perform the action without completing the password field.

I'm guessing the problem is here: app/Http/Controllers/Auth/LoginController.php, at the findOrCreateUser function, on line 104: 'password' => bcrypt(str_random(20))

@saleh-old
Copy link
Contributor

I was thinking of maybe putting a link or something to a help page guiding the user into doing a reset password and then deleting their account. But your suggestion sounds good too. Maybe check to see if the user has a verified email and if so, send a confirmation email; otherwise, ask for password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants