Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when running with JIT in Rails Ruby Bench #10

Open
noahgibbs opened this issue Feb 20, 2019 · 2 comments
Open

Exception when running with JIT in Rails Ruby Bench #10

noahgibbs opened this issue Feb 20, 2019 · 2 comments

Comments

@noahgibbs
Copy link

RRB is a pretty heavy usage test and I don't think you need to prioritize this.

The RTL branch ran RRB just fine without JIT, at basically the same speed as release Ruby 2.6. But it crashed rapidly when run with --jit. Here's the stack traces I got when it did:

Exception in worker thread: undefined method `setsockopt' for nil:NilClass
/home/ubuntu/mount-mjit/lib/ruby/2.6.0/net/http.rb:953:in `connect'
/home/ubuntu/mount-mjit/lib/ruby/2.6.0/net/http.rb:930:in `do_start'
/home/ubuntu/mount-mjit/lib/ruby/2.6.0/net/http.rb:919:in `start'
/home/ubuntu/.rvm/gems/ext-rtl-mjit/gems/rest-client-1.8.0/lib/restclient/request.rb:413:in `transmit'
/home/ubuntu/.rvm/gems/ext-rtl-mjit/gems/rest-client-1.8.0/lib/restclient/request.rb:176:in `execute'
/home/ubuntu/.rvm/gems/ext-rtl-mjit/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in `execute'
/home/ubuntu/rails_ruby_bench/user_simulator.rb:53:in `request'
/home/ubuntu/rails_ruby_bench/user_simulator.rb:72:in `action_from_args'
/home/ubuntu/rails_ruby_bench/user_simulator.rb:150:in `block in time_actions'
/home/ubuntu/rails_ruby_bench/user_simulator.rb:149:in `each'
/home/ubuntu/rails_ruby_bench/user_simulator.rb:149:in `time_actions'
/home/ubuntu/rails_ruby_bench/user_simulator.rb:179:in `block (2 levels) in multithreaded_actions'
#<Thread:0x0000562a0645be20@/home/ubuntu/rails_ruby_bench/user_simulator.rb:170 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
    11: from /home/ubuntu/rails_ruby_bench/user_simulator.rb:179:in `block (2 levels) in multithreaded_actions'
    10: from /home/ubuntu/rails_ruby_bench/user_simulator.rb:149:in `time_actions'
     9: from /home/ubuntu/rails_ruby_bench/user_simulator.rb:149:in `each'
     8: from /home/ubuntu/rails_ruby_bench/user_simulator.rb:150:in `block in time_actions'
     7: from /home/ubuntu/rails_ruby_bench/user_simulator.rb:72:in `action_from_args'
     6: from /home/ubuntu/rails_ruby_bench/user_simulator.rb:53:in `request'
     5: from /home/ubuntu/.rvm/gems/ext-rtl-mjit/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in `execute'
     4: from /home/ubuntu/.rvm/gems/ext-rtl-mjit/gems/rest-client-1.8.0/lib/restclient/request.rb:176:in `execute'
     3: from /home/ubuntu/.rvm/gems/ext-rtl-mjit/gems/rest-client-1.8.0/lib/restclient/request.rb:413:in `transmit'
     2: from /home/ubuntu/mount-mjit/lib/ruby/2.6.0/net/http.rb:919:in `start'
     1: from /home/ubuntu/mount-mjit/lib/ruby/2.6.0/net/http.rb:930:in `do_start'
/home/ubuntu/mount-mjit/lib/ruby/2.6.0/net/http.rb:953:in `connect': undefined method `setsockopt' for nil:NilClass (NoMethodError)

Release Ruby 2.6 didn't get these errors on the same EC2 instance.
@vnmakarov
Copy link
Owner

Noah, thank you for reporting this. I'll investigate this problem. Unfortunately, I am busy with GCC-9 release work for now. So I'll do this only after the GCC release (probably at the end of April).

@noahgibbs
Copy link
Author

Very reasonable. I just didn't want it to surprise you when I wrote that I couldn't use JIT for evaluating the RTL stuff in an upcoming blog post.

vnmakarov pushed a commit that referenced this issue Dec 8, 2022
@tenderlove
Always lookup IV buffers when iterating
2d86e79 
Always look up instance variable buffers when iterating.  It is possible
for the instance variable buffer to change out from under the object
during iteration, so we cannot cache the buffer on the stack.

In the case of Bug #19095, the transient heap moved the buffer during
iteration:

```
Watchpoint 1 hit:
old value: 0x0000000107c00df8
new value: 0x00000001032743c0
Process 31720 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = watchpoint 1
    frame #0: 0x00000001006e5178 miniruby`rb_obj_transient_heap_evacuate(obj=0x000000010d6b94b0, promote=1) at variable.c:1361:5
   1358	        }
   1359	        MEMCPY(new_ptr, old_ptr, VALUE, len);
   1360	        ROBJECT(obj)->as.heap.ivptr = new_ptr;
-> 1361	    }
   1362	}
   1363	#endif
   1364
miniruby`rb_obj_transient_heap_evacuate:
->  0x1006e5178 <+328>: b      0x1006e517c               ; <+332> at variable.c:1362:1
    0x1006e517c <+332>: ldp    x29, x30, [sp, #0x50]
    0x1006e5180 <+336>: add    sp, sp, #0x60
    0x1006e5184 <+340>: ret
Target 0: (miniruby) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = watchpoint 1
  * frame #0: 0x00000001006e5178 miniruby`rb_obj_transient_heap_evacuate(obj=0x000000010d6b94b0, promote=1) at variable.c:1361:5
    frame #1: 0x00000001006cb150 miniruby`transient_heap_block_evacuate(theap=0x0000000100b196c0, block=0x0000000107c00000) at transient_heap.c:734:17
    frame #2: 0x00000001006c854c miniruby`transient_heap_evacuate(dmy=0x0000000000000000) at transient_heap.c:808:17
    frame #3: 0x00000001007fe6c0 miniruby`rb_postponed_job_flush(vm=0x0000000104402900) at vm_trace.c:1773:21
    frame #4: 0x0000000100637a84 miniruby`rb_threadptr_execute_interrupts(th=0x0000000103803bc0, blocking_timing=0) at thread.c:2316:13
    frame #5: 0x000000010078b730 miniruby`rb_vm_check_ints(ec=0x00000001048038d0) at vm_core.h:2025:9
    frame #6: 0x00000001006fbd10 miniruby`vm_pop_frame(ec=0x00000001048038d0, cfp=0x0000000104a04440, ep=0x0000000104904a28) at vm_insnhelper.c:422:5
    frame #7: 0x00000001006fbca0 miniruby`rb_vm_pop_frame(ec=0x00000001048038d0) at vm_insnhelper.c:431:5
    frame #8: 0x00000001007d6420 miniruby`vm_call0_cfunc_with_frame(ec=0x00000001048038d0, calling=0x000000016fdcc6a0, argv=0x0000000000000000) at vm_eval.c:153:9
    frame #9: 0x00000001007d44cc miniruby`vm_call0_cfunc(ec=0x00000001048038d0, calling=0x000000016fdcc6a0, argv=0x0000000000000000) at vm_eval.c:164:12
    frame #10: 0x0000000100766e80 miniruby`vm_call0_body(ec=0x00000001048038d0, calling=0x000000016fdcc6a0, argv=0x0000000000000000) at vm_eval.c:210:15
    frame #11: 0x00000001007d76f0 miniruby`vm_call0_cc(ec=0x00000001048038d0, recv=0x000000010d6b49d8, id=2769, argc=0, argv=0x0000000000000000, cc=0x000000010d6b2e58, kw_splat=0) at vm_eval.c:87:12
    frame ruby#12: 0x0000000100769e48 miniruby`rb_funcallv_scope(recv=0x000000010d6b49d8, mid=2769, argc=0, argv=0x0000000000000000, scope=CALL_FCALL) at vm_eval.c:1051:16
    frame ruby#13: 0x0000000100760a54 miniruby`rb_funcallv(recv=0x000000010d6b49d8, mid=2769, argc=0, argv=0x0000000000000000) at vm_eval.c:1066:12
    frame ruby#14: 0x000000010037513c miniruby`rb_inspect(obj=0x000000010d6b49d8) at object.c:633:34
    frame ruby#15: 0x000000010002c950 miniruby`inspect_ary(ary=0x000000010d6b4938, dummy=0x0000000000000000, recur=0) at array.c:3091:13
    frame ruby#16: 0x0000000100642020 miniruby`exec_recursive(func=(miniruby`inspect_ary at array.c:3084), obj=0x000000010d6b4938, pairid=0x0000000000000000, arg=0x0000000000000000, outer=0, mid=2769) at thread.c:5177:23
    frame ruby#17: 0x00000001006412fc miniruby`rb_exec_recursive(func=(miniruby`inspect_ary at array.c:3084), obj=0x000000010d6b4938, arg=0x0000000000000000) at thread.c:5205:12
    frame ruby#18: 0x00000001000127f0 miniruby`rb_ary_inspect(ary=0x000000010d6b4938) at array.c:3117:12
```

In general though, any calls back out to the interpreter could change
the IV buffer, so it's not safe to cache.

[Bug #19095]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noahgibbs @vnmakarov