ginkgo error and possible flake

[jayunit100]

This could be a test run that im misinterpretting , happy to close this issue if so, but looks like theres some deflaking and test modernization for ginkgo we need to do

Bug description

It appears that this test might be flakey...

2022-12-13T17:52:52.3542020Z �[32m• [SLOW TEST:10.307 seconds]�[0m
2022-12-13T17:52:52.3542155Z KappControllerConfig Reconciler
2022-12-13T17:52:52.3542571Z �[90m/home/runner/work/tanzu-framework/tanzu-framework/addons/controllers/kappcontrollerconfig_controller_test.go:28�[0m
2022-12-13T17:52:52.3542858Z   Reconcile KappControllerConfig used as template
2022-12-13T17:52:52.3543510Z   �[90m/home/runner/work/tanzu-framework/tanzu-framework/addons/controllers/kappcontrollerconfig_controller_test.go:175�[0m
2022-12-13T17:52:52.3543671Z     Should skip the reconciliation
2022-12-13T17:52:52.3544216Z     �[90m/home/runner/work/tanzu-framework/tanzu-framework/addons/controllers/kappcontrollerconfig_controller_test.go:183�[0m
2022-12-13T17:52:52.3544395Z �[90m------------------------------�[0m
2022-12-13T17:52:52.3544530Z �[32m•�[0m�[32m•�[0m

The ginkgo test description is "clusterBootstrapTemplate" and "reconcilation" related:

ClusterBootstrap Reconciler � when cluster is created from clusterBootstrapTemplate �[0m�[90mfrom a ClusterBootstrapTemplate �[0m�[91m�[1m[It] should perform ClusterBootstrap reconciliation & block reconciliation if ClusterBootstrap gets paused �[0m
2022-12-13T17:52:52.3545961Z �[37m/home/runner/work/tanzu-framework/tanzu-framework/addons/controllers/clusterbootstrap_controller_test.go:914�

And i also see a ginkgo warning after it:

2022-12-13T17:52:52.3546948Z �[38;5;228mYou're using deprecated Ginkgo functionality:�[0m
2022-12-13T17:52:52.3547151Z �[38;5;228m=============================================�[0m
2022-12-13T17:52:52.3547814Z �[1m�[38;5;10mGinkgo 2.0�[0m is under active development and will introduce several new features, improvements, and a small handful of breaking changes.
2022-12-13T17:52:52.3548234Z A release candidate for 2.0 is now available and 2.0 should GA in Fall 2021.  �[1mPlease give the RC a try and send us feedback!�[0m
2022-12-13T17:52:52.3548748Z   - To learn more, view the migration guide at �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md�[0m
2022-12-13T17:52:52.3549540Z   - For instructions on using the Release Candidate visit �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#using-the-beta�[0m
2022-12-13T17:52:52.3550081Z   - To comment, chime in at �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/issues/711�[0m
2022-12-13T17:52:52.3550089Z 
2022-12-13T17:52:52.3550909Z   �[38;5;11mYou are passing a Done channel to a test node to test asynchronous behavior.  This is deprecated in Ginkgo V2.  Your test will run synchronously and the timeout will be ignored.�[0m

Affected product area (please put an X in all that apply)

• ( ) APIs
• ( ) Addons
• ( ) CLI
• ( ) Docs
• ( ) IAM
• ( ) Installation
• ( ) Plugin
• ( ) Security
• ( ) Test and Release
• ( ) User Experience
• ( x ) Developer Experience

Expected behavior

We wouldnt use Ginkgo deprecated functionality or have to consider it when debugging a test run, and, unit tests should always pass unless theres a bug.

Steps to reproduce the bug

make test seems to be a way to reproduce sometimes in CI jobs but not sure. i saw it here
https://pipelines.actions.githubusercontent.com/serviceHosts/751543ad-5af3-42f5-adf7-011709eeb5a2/_apis/pipelines/1/runs/78734/signedlogcontent/2?urlExpires=2022-12-13T18%3A58%3A18.2079400Z&urlSigningMethod=HMACV1&urlSignature=lQdQROuYszGYwasiHvFmbvhasFaUmJtx%2FIzj8uraTRo%3D

Version (include the SHA if the version is not obvious)
main
Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)