Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

hack/tools/bin out of sync can give odd local results #4165

Open
jayunit100 opened this issue Dec 13, 2022 · 0 comments · May be fixed by #4164
Open

hack/tools/bin out of sync can give odd local results #4165

jayunit100 opened this issue Dec 13, 2022 · 0 comments · May be fixed by #4164
Labels

Comments

@jayunit100
Copy link
Contributor

Bug description
Theres alot of compile deps, but the way we call hack/tools/Makefile doesnt clean them out which means that if you have older ytt like 3.0, youll get unobvious errors like

ytt: Error: Non-ytt comment at line upstream/metadata.yaml:1: '# maps release series of major.minor to cluster-api contract version':
  Unrecognized comment type (expected '#@' or '#!'). (hint: if this is plain YAML — not a template — consider `--file-mark '<filename>:type=yaml-plain'`)

This can cost hours of developer debugging on a local env. So we need to quickly test YTT (and optionally other versions) in the hack tools make flow, after running it so that we can inform users that they have a wrong version in their toolchain in the hack dir.

Affected product area (please put an X in all that apply)

  • ( ) APIs
  • ( ) Addons
  • ( ) CLI
  • ( ) Docs
  • ( ) IAM
  • ( ) Installation
  • ( ) Plugin
  • ( ) Security
  • ( x ) Test and Release
  • ( ) User Experience
  • ( x ) Developer Experience

Expected behavior

the make tools workflow will ensure that you either have the right tools, or explicitly fail.

Steps to reproduce the bug

install ytt 0.3.0 in hack/tools/bin and then run make test

Version (include the SHA if the version is not obvious)

main

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

@jayunit100 jayunit100 added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Dec 13, 2022
@codegold79 codegold79 added area/release area/testing and removed needs-triage Indicates an issue or PR needs to be triaged labels Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants