Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

make file: add npm install ? #6

Open
gedw99 opened this issue Sep 15, 2022 · 5 comments
Open

make file: add npm install ? #6

gedw99 opened this issue Sep 15, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@gedw99
Copy link

gedw99 commented Sep 15, 2022

i had to do a npm installand then make

Maybe add this to the an "init" target in the make file ?

@Angelmmiguel Angelmmiguel added the good first issue Good for newcomers label Sep 19, 2022
@Angelmmiguel
Copy link
Contributor

Hello @gedw99,

Thank you for your suggestion. Totally agree on having that as an extra step in the Makefile. We can create a separate node-modules target and add it as prerequisite for the build-client one.

This seems to be a great first issue to contribute on this project, so if you would like to do it, please feel free to open a new Pull Request. If you prefer us to apply the changes, happy to create the PR on our own :)

@gedw99
Copy link
Author

gedw99 commented Sep 19, 2022

I could not find a binary that installed javy for Mac also

@Angelmmiguel
Copy link
Contributor

@gedw99 do you refer to macOS Apple chipsets? I need to try it, but it seems they provide binaries for the two Applce chipset architectures: https://github.com/Shopify/javy/releases/tag/v0.3.0

@gedw99
Copy link
Author

gedw99 commented Sep 19, 2022

Thanks!!

Will pr a makefile update when I ge a chance

@Angelmmiguel
Copy link
Contributor

Thank you @gedw99! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants