Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Model]: facebook/seamless-m4t-v2-large #6017

Closed
frittentheke opened this issue Jul 1, 2024 · 3 comments
Closed

[New Model]: facebook/seamless-m4t-v2-large #6017

frittentheke opened this issue Jul 1, 2024 · 3 comments
Labels
new-model Requests to new models stale Over 90 days of inactivity

Comments

@frittentheke
Copy link
Contributor

frittentheke commented Jul 1, 2024

The model to consider.

https://huggingface.co/facebook/seamless-m4t-v2-large

The closest model vllm already supports.

No response

What's your difficulty of supporting the model you want?

The yet unsupported architecture SeamlessM4Tv2Model.

But the SeamlessM4Tv2Model does require encoders (https://github.com/huggingface/transformers/blob/e65502951593a76844e872fee9c56b805598538a/src/transformers/models/seamless_m4t_v2/modeling_seamless_m4t_v2.py#L4319) - Likely this is tackled with #187 ?

@frittentheke frittentheke added the new-model Requests to new models label Jul 1, 2024
@Micla-SHL
Copy link

Hi, I recently noticed this model: https://huggingface.co/facebook/seamless-m4t-v2-large.

My question:
documnent: https://docs.vllm.ai/en/latest/models/adding_model.html
Does this document also include guidelines for unsupported model architectures?

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Oct 25, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model Requests to new models stale Over 90 days of inactivity
Projects
None yet
Development

No branches or pull requests

3 participants
@frittentheke @Micla-SHL and others