-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Open
Labels
Description
We've seen a couple of recent cases where PR changes fail on main after being merged, but the same test that ran on the PR's CI prior to merge passed. It appears that the code which the passing test ran on wasn't the latest code from the PR branch.
This is separate to the issue of test scoping. In these cases the test in question did run and passed.
It also shouldn't be a consequence of the use of USE_PRECOMPILED_WHEELS
because the code differences in question were just changes to python files.
Examples:
- Tensorizer test: [Model loader]: support multi-thread model weight loading #23928 (comment)
- Basic models test: [BugFix][Spec Decode] Fix out-of-range index triggered by eagle3; re-enable test for LlamaForCausalLMEagle3 #24392
This is obviously very high priority since it's causing frequent unnecessary breakages to main.
cc @dougbtv
dougbtv