Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that fail on github runner #77

Open
OskarLiew opened this issue Feb 25, 2021 · 2 comments
Open

Tests that fail on github runner #77

OskarLiew opened this issue Feb 25, 2021 · 2 comments
Labels
bug Something isn't working TESTING

Comments

@OskarLiew
Copy link
Contributor

Some tests fail sometimes when run by the test runner. List them here:

  • tests/sdk_test/cli_test.py::test_logs_date_format
  • tests/sdk_test/cli_test.py::test_logs_stream
  • tests/sdk_test/mvi_test.py::test_entrypoint_monitored ..
  • tests/sdk_test/cli_test.py::test_deploy_and_kill - assert 1 == 0
  • tests/manager_test/local_docker_connection_test.py::test_starting_new_service
  • tests/sdk_test/daeploy_test.py::test_database_table_creation
@mile95 mile95 changed the title Issues that fail on github runner Tests that fail on github runner Feb 26, 2021
@mile95
Copy link
Contributor

mile95 commented Mar 1, 2021

  • FAILED tests/sdk_test/cli_test.py::test_deploy_and_kill - assert 1 == 0

@OskarLiew OskarLiew transferred this issue from another repository Apr 20, 2021
@OskarLiew
Copy link
Contributor Author

OskarLiew commented Dec 9, 2021

Majority of failing tests are due to race conditions in concurrency code. Github runner is slower than the development environment and therefore we get this more often. This has been mostly fixed for service database tests by waiting for threads to join before proceeding with the tests.

@OskarLiew OskarLiew transferred this issue from vikinganalytics/daeploy-issues Dec 9, 2021
@OskarLiew OskarLiew added bug Something isn't working TESTING labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working TESTING
Projects
None yet
Development

No branches or pull requests

2 participants