Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compileable in both Stable and Nightly Rust #3

Open
alexniver opened this issue Nov 9, 2024 · 1 comment · Fixed by #4
Open

Compileable in both Stable and Nightly Rust #3

alexniver opened this issue Nov 9, 2024 · 1 comment · Fixed by #4

Comments

@alexniver
Copy link

may be stable rust is better?

@victorb victorb reopened this Dec 23, 2024
@victorb victorb changed the title nightly rust? Compileable in both Stable and Nightly Rust Dec 23, 2024
@victorb
Copy link
Owner

victorb commented Dec 23, 2024

I've added Rust Stable as a CI target, so now we at least attempt to test both Stable and Nightly.

However, I'm using the bench feature which isn't available in Stable, so the benchmark kind of require Nightly. Didn't figure out how to skip that for Stable in the ~5 minutes I had available, so reopening this issue until I (or someone else) figured out how to skip that file for Rust Stable but not Nightly.

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/dogoap/benches/long_plan.rs:1:1
  |
1 | #![feature(test)]
  | ^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0554`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants