Skip to content

Commit be703ba

Browse files
authored
add option to include markdown docs to get_registry_item (#916)
1 parent b913639 commit be703ba

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/viam/app/app_client.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2095,7 +2095,7 @@ async def check_permissions(self, permissions: List[AuthorizedPermissions]) -> L
20952095
response: CheckPermissionsResponse = await self._app_client.CheckPermissions(request, metadata=self._metadata)
20962096
return list(response.authorized_permissions)
20972097

2098-
async def get_registry_item(self, item_id: str) -> RegistryItem:
2098+
async def get_registry_item(self, item_id: str, include_markdown_documentation: bool = False) -> RegistryItem:
20992099
"""Get registry item by ID.
21002100
21012101
::
@@ -2113,7 +2113,7 @@ async def get_registry_item(self, item_id: str) -> RegistryItem:
21132113
21142114
For more information, see `Fleet Management API <https://docs.viam.com/dev/reference/apis/fleet/#getregistryitem>`_.
21152115
"""
2116-
request = GetRegistryItemRequest(item_id=item_id)
2116+
request = GetRegistryItemRequest(item_id=item_id, include_markdown_documentation=include_markdown_documentation)
21172117
response: GetRegistryItemResponse = await self._app_client.GetRegistryItem(request, metadata=self._metadata)
21182118
return response.item
21192119

tests/mocks/services.py

+1
Original file line numberDiff line numberDiff line change
@@ -1698,6 +1698,7 @@ async def DeleteRegistryItem(self, stream: Stream[DeleteRegistryItemRequest, Del
16981698
async def GetRegistryItem(self, stream: Stream[GetRegistryItemRequest, GetRegistryItemResponse]) -> None:
16991699
request = await stream.recv_message()
17001700
assert request is not None
1701+
self.include_markdown_documentation = request.include_markdown_documentation
17011702
await stream.send_message(GetRegistryItemResponse(item=self.items[0]))
17021703

17031704

tests/test_app_client.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,8 @@ async def test_list_authorizations(self, service: MockApp):
655655
async def test_get_registry_item(self, service: MockApp):
656656
async with ChannelFor([service]) as channel:
657657
client = AppClient(channel, METADATA, ID)
658-
item = await client.get_registry_item(ID)
658+
item = await client.get_registry_item(ID, include_markdown_documentation=True)
659+
assert service.include_markdown_documentation is True
659660
assert item.item_id == ITEM.item_id
660661
assert item.name == ITEM.name
661662
assert item.visibility == ITEM.visibility

0 commit comments

Comments
 (0)