Skip to content

Commit 77e6c21

Browse files
authored
RSDK-8813: Add frame_rate to python sdk (#740)
1 parent f53775b commit 77e6c21

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

src/viam/components/camera/service.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,7 @@ async def GetProperties(self, stream: Stream[GetPropertiesRequest, GetProperties
8484
camera = self.get_resource(name)
8585
timeout = stream.deadline.time_remaining() if stream.deadline else None
8686
properties = await camera.get_properties(timeout=timeout, metadata=stream.metadata)
87-
response = GetPropertiesResponse(
88-
supports_pcd=properties.supports_pcd,
89-
intrinsic_parameters=properties.intrinsic_parameters,
90-
distortion_parameters=properties.distortion_parameters,
91-
mime_types=properties.mime_types,
92-
)
93-
await stream.send_message(response)
87+
await stream.send_message(properties)
9488

9589
async def DoCommand(self, stream: Stream[DoCommandRequest, DoCommandResponse]) -> None:
9690
request = await stream.recv_message()

tests/mocks/components.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ def __init__(self, name: str):
372372
intrinsic_parameters=IntrinsicParameters(width_px=1, height_px=2, focal_x_px=3, focal_y_px=4, center_x_px=5, center_y_px=6),
373373
distortion_parameters=DistortionParameters(model="no_distortion"),
374374
mime_types=[CameraMimeType.PNG, CameraMimeType.JPEG],
375+
frame_rate=10.0,
375376
)
376377
self.timeout: Optional[float] = None
377378
ts = Timestamp()

tests/test_camera.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ def properties() -> Camera.Properties:
6262
intrinsic_parameters=IntrinsicParameters(width_px=1, height_px=2, focal_x_px=3, focal_y_px=4, center_x_px=5, center_y_px=6),
6363
distortion_parameters=DistortionParameters(model="no_distortion"),
6464
mime_types=[CameraMimeType.PNG, CameraMimeType.JPEG],
65+
frame_rate=10.0,
6566
)
6667

6768

@@ -202,6 +203,7 @@ async def test_get_properties(self, camera: MockCamera, service: CameraRPCServic
202203
assert response.supports_pcd == properties.supports_pcd
203204
assert response.intrinsic_parameters == properties.intrinsic_parameters
204205
assert response.mime_types == properties.mime_types
206+
assert response.frame_rate == properties.frame_rate
205207
assert camera.timeout == loose_approx(5.43)
206208

207209
@pytest.mark.asyncio

0 commit comments

Comments
 (0)