Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic: Pass /Brepro to the linker when targeting Windows #38

Closed
alexrp opened this issue Jul 22, 2021 · 1 comment
Closed

Deterministic: Pass /Brepro to the linker when targeting Windows #38

alexrp opened this issue Jul 22, 2021 · 1 comment
Labels
area: tasks Issues related to MSBuild tasks.
Milestone
v6.0

Comments

@alexrp
Copy link
Member

alexrp commented Jul 22, 2021

Builds aren't actually deterministic on Windows yet.

See: ziglang/zig#9432
@alexrp alexrp added type: bug state: blocked Issues that are blocked on some other issue or work. area: tasks Issues related to MSBuild tasks. labels Jul 22, 2021
@alexrp alexrp added this to the v4.0 milestone Jul 22, 2021
@alexrp alexrp self-assigned this Jul 22, 2021
@alexrp alexrp modified the milestones: v4.0, v5.0 Sep 7, 2021
@MironAtHome MironAtHome mentioned this issue Nov 18, 2021
Closed
@alexrp alexrp modified the milestones: v5.0, v4.0 Dec 20, 2021
@alexrp alexrp modified the milestones: v5.0, Future Jan 1, 2024
@alexrp alexrp modified the milestones: Future, v6.0 Aug 1, 2024
@alexrp
Copy link
Member Author

alexrp commented Aug 1, 2024

This has been solved in Zig as of ziglang/zig#20811 and ziglang/zig#20840.

As of ziglang/zig#20821, Zig now also passes -Werror=date-time for us. Leaving this open to track removing that on our side.

@alexrp alexrp removed the type: bug label Oct 10, 2024
@alexrp alexrp added state: approved Enhancements and tasks that have been approved. and removed state: blocked Issues that are blocked on some other issue or work. labels Mar 5, 2025
alexrp added a commit that referenced this issue Mar 5, 2025
@alexrp
Stop passing -Werror=date-time.
9cd8d13 
Zig does this by default now.

Closes #38.
@alexrp alexrp closed this as completed in 1814f8a Mar 5, 2025
@alexrp alexrp removed the state: approved Enhancements and tasks that have been approved. label Mar 5, 2025
@alexrp alexrp removed their assignment Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tasks Issues related to MSBuild tasks.
Milestone
v6.0
Development

No branches or pull requests
1 participant
@alexrp