Skip to content

Commit 8606a2d

Browse files
authored
Merge pull request #24 from verypossible/update-to-1.27
Bump versions and set default to python3
2 parents d9b04a5 + 4f09997 commit 8606a2d

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:2.7.14
1+
FROM python:3.6.5
22

33
RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
44
RUN apt-get install -y \

Dockerfile-python3 Dockerfile-python2

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3.6.5
1+
FROM python:2.7.14
22

33
RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
44
RUN apt-get install -y \
@@ -20,7 +20,7 @@ RUN pip install \
2020

2121
ARG SERVERLESS_VERSION
2222
RUN npm install -g \
23-
serverless@${SERVERLESS_VERSION}
23+
serverless@${SERVERLESS_VERSION}
2424

2525
ARG YARN_VERSION
2626
RUN curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version ${YARN_VERSION}

Makefile

+8-7
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
NAME = verypossible/serverless
2-
VERSION = 1.26.1
2+
VERSION = 1.27.2
33
SERVERLESS_VERSION = $(VERSION)
4-
YARN_VERSION = 1.5.1
4+
YARN_VERSION = 1.6.0
55

66
.PHONY: all py2 py3 shell
77

@@ -10,21 +10,22 @@ all : py2 py3
1010

1111
py2 :
1212
docker build \
13-
-t $(NAME):$(VERSION) \
13+
-t $(NAME):$(VERSION)-python2 \
14+
-f Dockerfile-python2 \
1415
--build-arg SERVERLESS_VERSION=$(SERVERLESS_VERSION) \
1516
--build-arg YARN_VERSION=$(YARN_VERSION) \
1617
.
1718

1819
py3 :
1920
docker build \
20-
-t $(NAME):$(VERSION)-python3 \
21-
-f Dockerfile-python3 \
21+
-t $(NAME):$(VERSION) \
22+
-f Dockerfile \
2223
--build-arg SERVERLESS_VERSION=$(SERVERLESS_VERSION) \
2324
--build-arg YARN_VERSION=$(YARN_VERSION) \
2425
.
2526

2627
py2-shell :
27-
docker run --rm -it $(NAME):$(VERSION) bash
28+
docker run --rm -it $(NAME):$(VERSION)-python2 bash
2829

2930
py3-shell :
30-
docker run --rm -it $(NAME):$(VERSION)-python3 bash
31+
docker run --rm -it $(NAME):$(VERSION) bash

hooks/build

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ DOCKERFILE=Dockerfile
33

44
echo "Building $CACHE_TAG using build hook!"
55

6-
if [[ $CACHE_TAG == *"python3"* ]]; then
7-
DOCKERFILE=Dockerfile-python3
6+
if [[ $CACHE_TAG == *"python2"* ]]; then
7+
DOCKERFILE=Dockerfile-python2
88
fi
99

1010
echo "Using $DOCKERFILE for build"
1111

1212
docker build \
13-
--build-arg SERVERLESS_VERSION=1.26.1 \
14-
--build-arg YARN_VERSION=1.5.1 \
13+
--build-arg SERVERLESS_VERSION=1.27.2 \
14+
--build-arg YARN_VERSION=1.6.0 \
1515
-f $DOCKERFILE \
1616
-t $IMAGE_NAME .

0 commit comments

Comments
 (0)