Skip to content

Commit 08599b1

Browse files
committed
Update Dockerfiles
1 parent 71fbb2d commit 08599b1

File tree

5 files changed

+13
-17
lines changed

5 files changed

+13
-17
lines changed

README.adoc

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ First, generate the project from https://start.vertx.io:
3131
. Select the `JDK 11` JDK version
3232
. Click on generate and extract the content somewhere on your disk
3333

34-
image::using-maven.png[title="Generating a Maven Project", alt="Generating a Maven Project", align="center",width=80%]
35-
3634
Alternatively, open a terminal and run:
3735

3836
[source,bash]
@@ -66,8 +64,8 @@ endif::env-github[]
6664

6765
The Docker build has two stages:
6866

69-
. Building the Maven project inside a `maven:3.6.3-openjdk-11` container
70-
. Copying the output of the build in a `adoptopenjdk:11-jre-hotspot` container and configuring the entry point
67+
. Building the Maven project inside a `maven:3.9.9-eclipse-temurin-11` container
68+
. Copying the output of the build in a `eclipse-temurin:11` container and configuring the entry point
7169

7270
The benefits of this approach are:
7371

@@ -92,8 +90,6 @@ First, generate the project from https://start.vertx.io:
9290
. Select the `JDK 11` JDK version
9391
. Click on generate and extract the content somewhere on your disk
9492

95-
image::using-gradle.png[title="Generating a Gradle Project", alt="Generating a Gradle Project", align="center",width=80%]
96-
9793
Alternatively, open a terminal and run:
9894

9995
[source,bash]
@@ -127,8 +123,8 @@ endif::env-github[]
127123

128124
The Docker build has two stages:
129125

130-
. Building the Gradle project inside a `gradle:6.8.3-jdk11` container
131-
. Copying the output of the build in a `adoptopenjdk:11-jre-hotspot` container and configuring the entry point
126+
. Building the Gradle project inside a `gradle:8.1.1-jdk11` container
127+
. Copying the output of the build in a `eclipse-temurin:11` container and configuring the entry point
132128

133129
The benefits of this approach are:
134130

@@ -157,7 +153,7 @@ You should see messages like these on the console output:
157153

158154
----
159155
HTTP server started on port 8888
160-
Mar 16, 2021 2:45:57 PM io.vertx.core.impl.launcher.commands.VertxIsolatedDeployer
156+
Dec 02, 2024 5:17:19 PM io.vertx.launcher.application.VertxApplication
161157
INFO: Succeeded in deploying verticle
162158
----
163159

docker-gradle/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# 1st Docker build stage: build the project with Gradle
2-
FROM gradle:6.8.3-jdk11 as builder
2+
FROM gradle:8.11.1-jdk11 AS builder
33
WORKDIR /project
44
COPY . /project/
55
RUN gradle assemble --no-daemon
66

77
# 2nd Docker build stage: copy builder output and configure entry point
8-
FROM adoptopenjdk:11-jre-hotspot
9-
ENV APP_DIR /application
10-
ENV APP_FILE container-uber-jar.jar
8+
FROM eclipse-temurin:11
9+
ENV APP_DIR=/application
10+
ENV APP_FILE=container-uber-jar.jar
1111

1212
EXPOSE 8888
1313

docker-maven/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# 1st Docker build stage: build the project with Maven
2-
FROM maven:3.6.3-openjdk-11 as builder
2+
FROM maven:3.9.9-eclipse-temurin-11 AS builder
33
WORKDIR /project
44
COPY . /project/
55
RUN mvn package -DskipTests -B
66

77
# 2nd Docker build stage: copy builder output and configure entry point
8-
FROM adoptopenjdk:11-jre-hotspot
9-
ENV APP_DIR /application
10-
ENV APP_FILE container-uber-jar.jar
8+
FROM eclipse-temurin:11
9+
ENV APP_DIR=/application
10+
ENV APP_FILE=container-uber-jar.jar
1111

1212
EXPOSE 8888
1313

using-gradle.png

-74 KB
Binary file not shown.

using-maven.png

-74 KB
Binary file not shown.

0 commit comments

Comments
 (0)