[vpr] remove unnused variables + implictly deleted move assignment constructor

Author: amin1377

vpr/src/base/read_netlist.cpp

@@ -250,23 +250,6 @@ ClusteredNetlist read_netlist(const char* net_file,
 
     VTR_LOG("Finished loading packed FPGA netlist file (took %g seconds).\n", (float)(end - begin) / CLOCKS_PER_SEC);
 
-    size_t num_pb_route_used = 0;
-    size_t num_pb_route_alloc = 0;
-    size_t num_pb_pins = 0;
-    for (auto clb : clb_nlist.blocks()) {
-        t_pb* pb = clb_nlist.block_pb(clb);
-
-        for (int ipin = 0; ipin < pb->pb_graph_node->total_pb_pins; ++ipin) {
-            if (pb->pb_route.count(ipin)) {
-                ++num_pb_route_alloc;
-                if (pb->pb_route[ipin].atom_net_id) {
-                    ++num_pb_route_used;
-                }
-            }
-            ++num_pb_pins;
-        }
-    }
-
     return clb_nlist;
 }
 

vpr/src/draw/draw_toggle_functions.cpp

@@ -18,11 +18,6 @@
 #include <X11/keysym.h>
 #endif
 
-//The arrow head position for turning/straight-thru connections in a switch box
-constexpr float SB_EDGE_TURN_ARROW_POSITION = 0.2;
-constexpr float SB_EDGE_STRAIGHT_ARROW_POSITION = 0.95;
-constexpr float EMPTY_BLOCK_LIGHTEN_FACTOR = 0.20;
-
 /**
  * @brief toggles net drawing status based on status of combo box
  * updates draw_state->show_nets

vpr/src/draw/ui_setup.cpp

@@ -268,18 +268,15 @@ void load_block_names(ezgl::application* app) {
     auto& cluster_ctx = g_vpr_ctx.clustering();
     auto& atom_ctx = g_vpr_ctx.atom();
     GtkTreeIter iter;
-    int i = 0;
     for (ClusterBlockId id : cluster_ctx.clb_nlist.blocks()) {
         gtk_list_store_append(blockStorage, &iter);
         gtk_list_store_set(blockStorage, &iter,
                            0, (cluster_ctx.clb_nlist.block_name(id)).c_str(), -1);
-        i++;
     }
     for (AtomBlockId id : atom_ctx.netlist().blocks()) {
         gtk_list_store_append(blockStorage, &iter);
         gtk_list_store_set(blockStorage, &iter,
                            0, (atom_ctx.netlist().block_name(id)).c_str(), -1);
-        i++;
     }
 }
 
@@ -293,12 +290,10 @@ void load_net_names(ezgl::application* app) {
     auto& atom_ctx = g_vpr_ctx.atom();
     GtkTreeIter iter;
     //Loading net names
-    int i = 0;
     for (AtomNetId id : atom_ctx.netlist().nets()) {
         gtk_list_store_append(netStorage, &iter);
         gtk_list_store_set(netStorage, &iter,
                            0, (atom_ctx.netlist().net_name(id)).c_str(), -1);
-        i++;
     }
 }
 

vpr/src/pack/pb_type_graph_annotations.cpp

@@ -118,7 +118,7 @@ void load_pb_graph_pin_to_pin_annotations(t_pb_graph_node* pb_graph_node) {
  * Add the pattern name to the pack_pattern field for each pb_graph_edge that is used in a pack pattern
  */
 static void load_pack_pattern_annotations(const int line_num, t_pb_graph_node* pb_graph_node, const int mode, const char* annot_in_pins, const char* annot_out_pins, const std::string& value) {
-    int i, j, k, m, n, p, iedge;
+    int i, j, m, n, iedge;
     t_pb_graph_pin ***in_port, ***out_port;
     int *num_in_ptrs, *num_out_ptrs, num_in_sets, num_out_sets;
     t_pb_graph_node** children = nullptr;
@@ -130,10 +130,8 @@ static void load_pack_pattern_annotations(const int line_num, t_pb_graph_node* p
                                                         annot_out_pins, &num_out_ptrs, &num_out_sets, false, false);
 
     /* Discover edge then annotate edge with name of pack pattern */
-    k = 0;
     for (i = 0; i < num_in_sets; i++) {
         for (j = 0; j < num_in_ptrs[i]; j++) {
-            p = 0;
             for (m = 0; m < num_out_sets; m++) {
                 for (n = 0; n < num_out_ptrs[m]; n++) {
                     for (iedge = 0; iedge < in_port[i][j]->num_output_edges; iedge++) {
@@ -148,10 +146,8 @@ static void load_pack_pattern_annotations(const int line_num, t_pb_graph_node* p
                         in_port[i][j]->output_edges[iedge]->pack_pattern_names.resize(in_port[i][j]->output_edges[iedge]->num_pack_patterns);
                         in_port[i][j]->output_edges[iedge]->pack_pattern_names[in_port[i][j]->output_edges[iedge]->num_pack_patterns - 1] = value.c_str(); // TODO: convert to std::string
                     }
-                    p++;
                 }
             }
-            k++;
         }
     }
 

vpr/src/place/noc_place_utils.h

@@ -31,7 +31,7 @@ class NocCostHandler {
     NocCostHandler(const NocCostHandler&) = delete;
     NocCostHandler& operator=(const NocCostHandler&) = delete;
     NocCostHandler(NocCostHandler&&) = default;
-    NocCostHandler& operator=(NocCostHandler&&) = default;
+    NocCostHandler& operator=(NocCostHandler&&) = delete;
 
     /**
      * @brief Check if the internal reference to block_locs is pointing to the same