Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the new Cache API with common use cases #94

Closed
5 tasks done
shuding opened this issue May 8, 2021 · 3 comments
Closed
5 tasks done

Document the new Cache API with common use cases #94

shuding opened this issue May 8, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@shuding
Copy link
Member

shuding commented May 8, 2021

Related

@shuding shuding added the documentation Improvements or additions to documentation label May 8, 2021
@skotchpine
Copy link

Loving the library, thanks for being conservative, having docs, etc. Go you!

@shuding is our solution here affected? vercel/swr#488

@shuding
Copy link
Member Author

shuding commented May 23, 2021

@skotchpine yep @huozhi is working on it in #99. You're solution will be affected, but we're going to put an example in the docs that solves the exact same problem with a more flexible way.

The old API is not ideal and we don't want people to stick with it before we have a proper solution (otherwise they have to migrate their code), that's why we didn't document it.

@huozhi
Copy link
Member

huozhi commented Jul 22, 2021

Close this issue as cache examples are kind enough, add test solution is also resolved

@huozhi huozhi closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants