fix term crash when bell is false

Author: LabhanshAgrawal

app/config/schema.json

@@ -33,7 +33,10 @@
                 },
                 "bell": {
                     "description": "Supported Options:\n1. 'SOUND' -> Enables the bell as a sound\n2. false: turns off the bell",
-                    "type": "string"
+                    "enum": [
+                        "SOUND",
+                        false
+                    ]
                 },
                 "bellSound": {
                     "description": "base64 encoded string of the sound file to use for the bell\nif null, the default bell will be used",
@@ -357,7 +360,10 @@
                         },
                         "bell": {
                             "description": "Supported Options:\n1. 'SOUND' -> Enables the bell as a sound\n2. false: turns off the bell",
-                            "type": "string"
+                            "enum": [
+                                "SOUND",
+                                false
+                            ]
                         },
                         "bellSound": {
                             "description": "base64 encoded string of the sound file to use for the bell\nif null, the default bell will be used",

lib/components/term.tsx

@@ -416,8 +416,8 @@ export default class Term extends React.PureComponent<
     return !e.catched;
   }
 
-  setBellSound(bell: string | null, sound: string | null) {
-    if (bell?.toUpperCase() === 'SOUND') {
+  setBellSound(bell: 'SOUND' | false, sound: string | null) {
+    if (bell && bell.toUpperCase() === 'SOUND') {
       this.bellSound = sound ? new Audio(sound) : this.defaultBellSound;
     } else {
       this.bellSound = null;

lib/config.d.ts

@@ -46,7 +46,7 @@ type profileConfigOptions = {
    * 1. 'SOUND' -> Enables the bell as a sound
    * 2. false: turns off the bell
    */
-  bell: string;
+  bell: 'SOUND' | false;
   /**
    * base64 encoded string of the sound file to use for the bell
    * if null, the default bell will be used

lib/hyper.d.ts

@@ -47,7 +47,7 @@ export type uiState = Immutable<{
   activeUid: string | null;
   activityMarkers: Record<string, boolean>;
   backgroundColor: string;
-  bell: string;
+  bell: 'SOUND' | false;
   bellSoundURL: string | null;
   bellSound: string | null;
   borderColor: string;
@@ -347,7 +347,7 @@ import type {FitAddon} from 'xterm-addon-fit';
 import type {SearchAddon} from 'xterm-addon-search';
 export type TermProps = {
   backgroundColor: string;
-  bell: string;
+  bell: 'SOUND' | false;
   bellSound: string | null;
   bellSoundURL: string | null;
   borderColor: string;

lib/reducers/ui.ts

@@ -217,7 +217,7 @@ const reducer: IUiReducer = (state = initial, action) => {
             }
 
             if (allowedBells.has(config.bell)) {
-              ret.bell = config.bell;
+              ret.bell = (config.bell as any) === 'false' ? false : config.bell;
             }
 
             if (config.bellSoundURL !== state.bellSoundURL) {