Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url for video embed links with percent encoded brackets is altered when saved #229

Open
sparkalow opened this issue Feb 6, 2025 · 1 comment

Comments

@sparkalow
Copy link

Describe the bug

Here is an example Wistia embed url that contains parameters to enable captions and set a default language for the captions.

https://fast.wistia.net/embed/iframe/zs8hlyi5xz?plugin%5Bcaptions-v1%5D%5BonByDefault%5D=true&plugin%5Bcaptions-v1%5D%5Blanguage%5D=spa

When pasting in that url to a video embed link, it is transformed to this url after save:
https://fast.wistia.net/embed/iframe/zs8hlyi5xz?plugin%5Bcaptions-v1%5D%5BonByDefault%5D=true

Note this example video does not actually have captions.
reference for that ugly url : Wistia Embed options

Steps to reproduce

  1. Use a link field
  2. Paste in this url https://fast.wistia.net/embed/iframe/zs8hlyi5xz?plugin%5Bcaptions-v1%5D%5BonByDefault%5D=true&plugin%5Bcaptions-v1%5D%5Blanguage%5D=spa
  3. Save
  4. Notice the saved url differs from what was pasted

Craft CMS version

Craft Pro 5.6.0.2

Plugin version

Hyper 2.2.2

Multi-site?

No response

Additional context

When pasting the example link in a "url" linkType field, it works as expected.

@engram-design
Copy link
Member

Fixed for the next release. To get this early, run composer require verbb/hyper:"dev-craft-5 as 2.2.2".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants