Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing conformance checks and e2e test #18

Open
cowbon opened this issue Jan 15, 2025 · 1 comment
Open

Missing conformance checks and e2e test #18

cowbon opened this issue Jan 15, 2025 · 1 comment

Comments

@cowbon
Copy link
Collaborator

cowbon commented Jan 15, 2025

Several checks are still missing from ratsd

  1. Nonce validation. There should be a data size limit for the nonce
  2. Ratsd should issue bearer tokens for request authentication
  3. The E2E test and smoke tests for every builds
@thomas-fossati
Copy link
Contributor

With regards to

The E2E test and smoke tests for every builds

I think unit tests may be sufficient.

Besides, we'll need to set a coverage threshold and check that a PR doesn't decrease it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants