Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Self Destruct not working as expected #1023

Open
kheckwrecker opened this issue Feb 5, 2025 · 11 comments
Open

Auto Self Destruct not working as expected #1023

kheckwrecker opened this issue Feb 5, 2025 · 11 comments
Labels

Comments

@kheckwrecker
Copy link

kheckwrecker commented Feb 5, 2025

When in space, if I hit the ! (Shift+1), all my weapons in my HUD turn red, but the rest of my ship remains intact. I can fly around and even land. If I hit ! again while approaching a planet the self-destruct will work, but I'm pretty sure it's supposed to work as soon as I hit ! at any time in space.

@royfalk royfalk added the bug label Feb 6, 2025
@royfalk
Copy link
Contributor

royfalk commented Feb 8, 2025

What branches (engine/assets) are you running?
Also, what ship?

I also tried Vigilance (one time) in master/master and the ship was destroyed but I auto-ejected.
I just tried both Vigilance and Llama.begin in branches task_armor_2 (engine)/task_armor (assets) several times and it works fine.

@BenjamenMeyer , @stephengtuggy , @evertvorster - what do you think is the right behavior. Should auto-eject be applied here? Auto-eject typically applies x% of the time. I'm not sure if this is the case here or if I changed something in #1016.

@kheckwrecker
Copy link
Author

I was playing master/master with a dostoevsky.

My opinion is that auto-destruct should completely destroy your ship and give you the option of re-loading or quitting.

@stephengtuggy
Copy link
Contributor

It only self-destructs a certain percentage of the time. It’s been that way for a while now, probably at least a year. This is not the correct behavior though. Auto Self Destruct should always completely destroy ship, pilot, and pilot pod, and take you to the Grim Reaper screen where you can either respawn or quit. This expected behavior is more or less implied by the name of the keyboard function (“Auto Self Destruct”).

It would be nice to get this fixed finally.

@kheckwrecker
Copy link
Author

Auto Self Destruct should always completely destroy ship, pilot, and pilot pod, and take you to the Grim Reaper screen where you can either respawn or quit. This expected behavior is more or less implied by the name of the keyboard function (“Auto Self Destruct”).

I agree, and I also think (even though it's not a bug) that the way "quit" works should change. I did start a Discussion on it, since it's not a bug, but rather a request for change (sometime down the road).

@BenjamenMeyer
Copy link
Member

I'll agree with @stephengtuggy on the fix.

@vincele
Copy link
Contributor

vincele commented Mar 9, 2025

I often (everytime I do some test run) press SHIFT + "1" on my french keyboard (AZERTY, this should be a "1" keypress event) and it always works as intended.

Is there a way to get a dostoevsky ship easily (infinite money cheat mode, or something like that)?

@BenjamenMeyer
Copy link
Member

Is there a way to get a dostoevsky ship easily (infinite money cheat mode, or something like that)?

Edit the saved game file under ~/.vegastrike/save/ and give yourself money.

@vincele
Copy link
Contributor

vincele commented Mar 9, 2025

That's way too easy, I wanted to have to decompile a binary or use an hex editor...

EDIT: Cannot reproduce with a dostoevsky, ASD => ship explodes properly.

@BenjamenMeyer
Copy link
Member

That's way too easy, I wanted to have to decompile a binary or use an hex editor...

It'll be slightly harder once we move to a new save file format since then you'd have to unzip/modify/zip... may be do a hash step too. But that'll be a while until we do that.

@vincele
Copy link
Contributor

vincele commented Mar 10, 2025

That was a joke. I think it's fine as-is. Why would we want to obfuscate it ? The cheaters will always find a way. It removes the fun from gaming anyways...

@BenjamenMeyer
Copy link
Member

That was a joke. I think it's fine as-is. Why would we want to obfuscate it ? The cheaters will always find a way. It removes the fun from gaming anyways...

the format change won't be to obfuscate anything but to pull all the data together into a single file; it just happens to require more steps for doing this kind of thing; though we'll probably also have a saved game editor too so it might even become easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants