chore: Apply clippy lints from 1.59.0

Signed-off-by: Jesse Szwedko <[email protected]>

Author: jszwedko

lib/datadog/grok/src/matchers/date.rs

@@ -108,17 +108,12 @@ fn parse_tz_id_or_name(tz: &str) -> Result<FixedOffset, String> {
 }
 
 fn parse_offset(tz: &str) -> Result<FixedOffset, String> {
-    let offset_format;
     if tz.len() <= 3 {
         // +5, -12
         let hours_diff = tz.parse::<i32>().map_err(|e| e.to_string())?;
         return Ok(FixedOffset::east(hours_diff * 3600));
     }
-    if tz.contains(':') {
-        offset_format = "%:z";
-    } else {
-        offset_format = "%z";
-    }
+    let offset_format = if tz.contains(':') { "%:z" } else { "%z" };
     // apparently the easiest way to parse tz offset is parsing the complete datetime
     let date_str = format!("2020-04-12 22:10:57 {}", tz);
     let datetime =

lib/datadog/search-syntax/src/field.rs

@@ -59,7 +59,7 @@ pub fn normalize_fields<T: AsRef<str>>(value: T) -> Vec<Field> {
             .collect();
     }
 
-    let field = match value.replace("@", "custom.") {
+    let field = match value.replace('@', "custom.") {
         v if value.starts_with('@') => Field::Facet(v),
         v if DEFAULT_FIELDS.contains(&v.as_ref()) => Field::Default(v),
         v if RESERVED_ATTRIBUTES.contains(&v.as_ref()) => Field::Reserved(v),

lib/dnsmsg-parser/src/dns_message_parser.rs

@@ -1033,7 +1033,7 @@ fn parse_character_string(decoder: &mut BinDecoder<'_>) -> DnsParserResult<Strin
                 "Unexpected data length: expected {}, got {}. Raw data {}",
                 len,
                 raw_data.len(),
-                format_bytes_as_hex_string(&raw_data.to_vec())
+                format_bytes_as_hex_string(raw_data)
             ),
         }),
     }
@@ -1106,7 +1106,7 @@ fn parse_domain_name(decoder: &mut BinDecoder<'_>) -> DnsParserResult<Name> {
 }
 
 fn escape_string_for_text_representation(original_string: String) -> String {
-    original_string.replace("\\", "\\\\").replace("\"", "\\\"")
+    original_string.replace('\\', "\\\\").replace('\"', "\\\"")
 }
 
 fn parse_unknown_record_type(rtype: u16) -> Option<String> {

lib/file-source/src/fingerprinter.rs

@@ -456,7 +456,7 @@ mod test {
         let mut small_files = HashSet::new();
         assert!(fingerprinter
             .get_fingerprint_or_log_error(
-                &target_dir.path().to_owned(),
+                target_dir.path(),
                 &mut buf,
                 &mut small_files,
                 &NoErrors

lib/file-source/src/paths_provider/glob.rs

@@ -35,9 +35,7 @@ impl<E: FileSourceInternalEvents> Glob<E> {
             .collect::<Option<_>>()?;
 
         let exclude_patterns = exclude_patterns
-            .iter()
-            .map(|path| path.to_str().map(|path| Pattern::new(path).ok()))
-            .flatten()
+            .iter().filter_map(|path| path.to_str().map(|path| Pattern::new(path).ok()))
             .collect::<Option<Vec<_>>>()?;
 
         Some(Self {

lib/k8s-e2e-tests/src/lib.rs

@@ -45,7 +45,7 @@ pub fn get_override_name(namespace: &str, suffix: &str) -> String {
 
 /// Is the MULTINODE environment variable set?
 pub fn is_multinode() -> bool {
-    env::var("MULTINODE".to_string()).is_ok()
+    env::var("MULTINODE").is_ok()
 }
 
 /// Create config adding fullnameOverride entry. This allows multiple tests

lib/k8s-test-framework/src/kubernetes_version.rs

@@ -23,14 +23,14 @@ pub async fn get(kubectl_command: &str) -> Result<K8sVersion> {
     let json: serde_json::Value = serde_json::from_slice(&reader.stdout)?;
 
     Ok(K8sVersion {
-        major: json["serverVersion"]["major"].to_string().replace("\"", ""),
-        minor: json["serverVersion"]["minor"].to_string().replace("\"", ""),
+        major: json["serverVersion"]["major"].to_string().replace('\"', ""),
+        minor: json["serverVersion"]["minor"].to_string().replace('\"', ""),
         platform: json["serverVersion"]["platform"]
             .to_string()
-            .replace("\"", ""),
+            .replace('\"', ""),
         git_version: json["serverVersion"]["gitVersion"]
             .to_string()
-            .replace("\"", ""),
+            .replace('\"', ""),
     })
 }
 

lib/lookup/src/lookup_buf/segmentbuf.rs

@@ -64,7 +64,7 @@ impl Arbitrary for FieldBuf {
         let name = (0..len)
             .map(|_| chars[usize::arbitrary(g) % chars.len()])
             .collect::<String>()
-            .replace(r#"""#, r#"\""#);
+            .replace('"', r#"\""#);
         FieldBuf::from(name)
     }
 
@@ -74,7 +74,7 @@ impl Arbitrary for FieldBuf {
                 .shrink()
                 .filter(|name| !name.is_empty())
                 .map(|name| {
-                    let name = name.replace(r#"""#, r#"/""#);
+                    let name = name.replace('"', r#"/""#);
                     FieldBuf::from(name)
                 }),
         )

lib/value/src/value/api.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::use_self)] // I don't think Self can be used here, it creates a cycle
+
 use async_graphql::scalar;
 
 use crate::value::Value;

lib/value/src/value/display.rs

@@ -9,9 +9,9 @@ impl fmt::Display for Value {
                 f,
                 r#""{}""#,
                 String::from_utf8_lossy(val)
-                    .replace(r#"\"#, r#"\\"#)
-                    .replace(r#"""#, r#"\""#)
-                    .replace("\n", r#"\n"#)
+                    .replace('\\', r#"\\"#)
+                    .replace('"', r#"\""#)
+                    .replace('\n', r#"\n"#)
             ),
             Value::Integer(val) => write!(f, "{}", val),
             Value::Float(val) => write!(f, "{}", val),