refactor!(pytest plugin[hg]) Session-scoped, cached VCS fixtures

Author: tony

src/libvcs/pytest_plugin.py

@@ -552,12 +552,34 @@ def hg_remote_repo_single_commit_post_init(remote_repo_path: pathlib.Path) -> No
     run(["hg", "commit", "-m", "test file for hg repo"], cwd=remote_repo_path)
 
 
-@pytest.fixture
+@pytest.fixture(scope="session")
+def empty_hg_repo_path(libvcs_test_cache_path: pathlib.Path) -> pathlib.Path:
+    """Return temporary directory to use for master-copy of a hg repo."""
+    return libvcs_test_cache_path / "empty_hg_repo"
+
+
+@pytest.fixture(scope="session")
+@skip_if_hg_missing
+def empty_hg_repo(
+    empty_hg_repo_path: pathlib.Path,
+) -> pathlib.Path:
+    """Return factory to create hg remote repo to for clone / push purposes."""
+    if empty_hg_repo_path.exists() and (empty_hg_repo_path / ".hg").exists():
+        return empty_hg_repo_path
+
+    return _create_hg_remote_repo(
+        remote_repos_path=empty_hg_repo_path.parent,
+        remote_repo_name=empty_hg_repo_path.stem,
+        remote_repo_post_init=None,
+        init_cmd_args=None,
+    )
+
+
+@pytest.fixture(scope="session")
 @skip_if_hg_missing
 def create_hg_remote_repo(
     remote_repos_path: pathlib.Path,
-    hgconfig: pathlib.Path,
-    set_home: pathlib.Path,
+    empty_hg_repo: pathlib.Path,
 ) -> CreateRepoPytestFixtureFn:
     """Pre-made hg repo, bare, used as a file:// remote to checkout and commit to."""
 
@@ -567,30 +589,39 @@ def fn(
         remote_repo_post_init: Optional[CreateRepoPostInitFn] = None,
         init_cmd_args: InitCmdArgs = None,
     ) -> pathlib.Path:
-        return _create_hg_remote_repo(
-            remote_repos_path=remote_repos_path,
-            remote_repo_name=remote_repo_name
-            if remote_repo_name is not None
-            else unique_repo_name(remote_repos_path=remote_repos_path),
-            remote_repo_post_init=remote_repo_post_init,
-            init_cmd_args=init_cmd_args,
-        )
+        if remote_repo_name is None:
+            remote_repo_name = unique_repo_name(remote_repos_path=remote_repos_path)
+        remote_repo_path = remote_repos_path / remote_repo_name
+
+        shutil.copytree(empty_hg_repo, remote_repo_path)
+
+        if remote_repo_post_init is not None and callable(remote_repo_post_init):
+            remote_repo_post_init(remote_repo_path=remote_repo_path)
+
+        assert empty_hg_repo.exists()
+
+        assert remote_repo_path.exists()
+
+        return remote_repo_path
 
     return fn
 
 
-@pytest.fixture
+@pytest.fixture(scope="session")
 @skip_if_hg_missing
 def hg_remote_repo(
     remote_repos_path: pathlib.Path,
-    hgconfig: pathlib.Path,
+    create_hg_remote_repo: CreateRepoPytestFixtureFn,
 ) -> pathlib.Path:
     """Pre-made, file-based repo for push and pull."""
-    return _create_hg_remote_repo(
-        remote_repos_path=remote_repos_path,
-        remote_repo_name="dummyrepo",
-        remote_repo_post_init=hg_remote_repo_single_commit_post_init,
-    )
+    # return _create_hg_remote_repo(
+    #     remote_repos_path=remote_repos_path,
+    #     remote_repo_name="dummyrepo",
+    #     remote_repo_post_init=hg_remote_repo_single_commit_post_init,
+    # )
+    repo_path = create_hg_remote_repo()
+    hg_remote_repo_single_commit_post_init(remote_repo_path=repo_path)
+    return repo_path
 
 
 @pytest.fixture
@@ -640,6 +671,7 @@ def add_doctest_fixtures(
     tmp_path: pathlib.Path,
     set_home: pathlib.Path,
     gitconfig: pathlib.Path,
+    hgconfig: pathlib.Path,
     create_git_remote_repo: CreateRepoPytestFixtureFn,
     create_svn_remote_repo: CreateRepoPytestFixtureFn,
     create_hg_remote_repo: CreateRepoPytestFixtureFn,
@@ -667,6 +699,7 @@ def add_doctest_fixtures(
             remote_repo_post_init=svn_remote_repo_single_commit_post_init,
         )
     if shutil.which("hg"):
+        doctest_namespace["hgconfig"] = hgconfig
         doctest_namespace["create_hg_remote_repo_bare"] = create_hg_remote_repo
         doctest_namespace["create_hg_remote_repo"] = functools.partial(
             create_hg_remote_repo,